audio API: Use an enum for audio device device type

audio API: Use an enum for audio device device type

BUG=685382
Review-Url: https://codereview.chromium.org/2657423003
Cr-Commit-Position: refs/heads/master@{#449683}
Committed: https://chromium.googlesource.com/chromium/src/+/ca502648e278434f85f196f7211ba0e7d0130dfd

[tbarzic, 2017-01-29 04:55:17]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 04:55:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 05:38:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 05:38:56]

Dry run: This issue passed the CQ dry run.

[tbarzic, 2017-01-30 18:45:39]

tbarzic@chromium.org changed reviewers:
+ jennyz@chromium.org, rdevlin.cronin@chromium.org

[Devlin, 2017-01-30 21:32:38]

lgtm; thanks for the cleanup!

https://codereview.chromium.org/2657423003/diff/1/extensions/browser/api/audi...
File extensions/browser/api/audio/audio_service_chromeos.cc (right):

https://codereview.chromium.org/2657423003/diff/1/extensions/browser/api/audi...
extensions/browser/api/audio/audio_service_chromeos.cc:60: }
nit: should there be a NOTREACHED() here?

[tbarzic, 2017-01-30 21:46:28]

https://codereview.chromium.org/2657423003/diff/1/extensions/browser/api/audi...
File extensions/browser/api/audio/audio_service_chromeos.cc (right):

https://codereview.chromium.org/2657423003/diff/1/extensions/browser/api/audi...
extensions/browser/api/audio/audio_service_chromeos.cc:60: }
On 2017/01/30 21:32:38, Devlin wrote:
> nit: should there be a NOTREACHED() here?

yep, there probably should.

[tbarzic, 2017-02-07 20:21:51]

On 2017/01/30 21:46:28, tbarzic wrote:
>
https://codereview.chromium.org/2657423003/diff/1/extensions/browser/api/audi...
> File extensions/browser/api/audio/audio_service_chromeos.cc (right):
> 
>
https://codereview.chromium.org/2657423003/diff/1/extensions/browser/api/audi...
> extensions/browser/api/audio/audio_service_chromeos.cc:60: }
> On 2017/01/30 21:32:38, Devlin wrote:
> > nit: should there be a NOTREACHED() here?
> 
> yep, there probably should.

jenny, ping.

[jennyz, 2017-02-10 18:08:57]

lgtm

[tbarzic, 2017-02-10 18:16:30]

The CQ bit was checked by tbarzic@chromium.org

[tbarzic, 2017-02-10 18:16:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2657423003/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-02-10 18:17:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 19:12:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486750590347290,
"parent_rev": "4163c4542960b48b8d23e3ad4d0591c3c53d71f1", "commit_rev":
"1c039469ae2cc80ef0265f94cb4459776a2dafaa"}

[commit-bot: I haz the power, 2017-02-10 19:16:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486750590347290,
"parent_rev": "634eb441a23de402679696c5256747528ec6f9a4", "commit_rev":
"ca502648e278434f85f196f7211ba0e7d0130dfd"}

[commit-bot: I haz the power, 2017-02-10 19:16:50]

Description was changed from

==========
audio API: Use an enum for audio device device type

BUG=685382
==========

to

==========
audio API: Use an enum for audio device device type

BUG=685382

Review-Url: https://codereview.chromium.org/2657423003
Cr-Commit-Position: refs/heads/master@{#449683}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca502648e278434f85f196f7211b...
==========

[commit-bot: I haz the power, 2017-02-10 19:16:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ca502648e278434f85f196f7211b...