Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2657393002: Revert of [stubs] KeyedLoadIC_Generic: prototype chain lookup support (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [stubs] KeyedLoadIC_Generic: prototype chain lookup support (patchset #2 id:20001 of https://codereview.chromium.org/2652213003/ ) Reason for revert: Speculative revert for breaking a layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/13113 Unfortunately, the test results archive is not giving much info this time. Original issue's description: > [stubs] KeyedLoadIC_Generic: prototype chain lookup support > > Performing lookups on the prototype chain in the stub avoids a > bunch of slow-path runtime calls. For now, only receivers with > dictionary-mode properties do this; fast-mode receivers will follow > if it's beneficial. > > Review-Url: https://codereview.chromium.org/2652213003 > Cr-Commit-Position: refs/heads/master@{#42751} > Committed: https://chromium.googlesource.com/v8/v8/+/82e10f5fbacbbd71bc65e99322f432470692bf41 TBR=ishell@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2657393002 Cr-Commit-Position: refs/heads/master@{#42754} Committed: https://chromium.googlesource.com/v8/v8/+/291d9a782f9e3f5c56940062250a16ca60f85c64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -48 lines) Patch
M src/ic/accessor-assembler.cc View 3 chunks +2 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [stubs] KeyedLoadIC_Generic: prototype chain lookup support
3 years, 10 months ago (2017-01-28 11:23:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657393002/1
3 years, 10 months ago (2017-01-28 11:23:22 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 11:23:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/291d9a782f9e3f5c56940062250a16ca60f...

Powered by Google App Engine
This is Rietveld 408576698