Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1638)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2657323003: Convert HistoryTabHelper to use the new navigation callbacks. (Closed)
Patch Set: better fix to send this data from the renderer initially Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 71213fce8182bc921564fdfe5a70ff0f05004e79..92de68e2f7be44801d225f4926814ba29184ff6b 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3456,8 +3456,11 @@ void RenderFrameImpl::didStartProvisionalLoad(blink::WebLocalFrame* frame) {
for (auto& observer : observers_)
observer.DidStartProvisionalLoad();
+ std::vector<GURL> redirect_chain;
+ GetRedirectChain(ds, &redirect_chain);
+ CHECK(!redirect_chain.empty());
Send(new FrameHostMsg_DidStartProvisionalLoad(
- routing_id_, ds->getRequest().url(), navigation_start));
+ routing_id_, ds->getRequest().url(), redirect_chain, navigation_start));
}
void RenderFrameImpl::didReceiveServerRedirectForProvisionalLoad(
@@ -6235,6 +6238,9 @@ void RenderFrameImpl::BeginNavigation(const NavigationPolicyInfo& info) {
web_searchable_form_data.encoding().utf8();
}
+ if (info.isClientRedirect)
+ begin_navigation_params.client_side_redirect_url = frame_->document().url();
+
Send(new FrameHostMsg_BeginNavigation(
routing_id_, MakeCommonNavigationParams(info), begin_navigation_params));
}

Powered by Google App Engine
This is Rietveld 408576698