Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: content/public/browser/navigation_handle.cc

Issue 2657323003: Convert HistoryTabHelper to use the new navigation callbacks. (Closed)
Patch Set: better fix to send this data from the renderer initially Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.cc
diff --git a/content/public/browser/navigation_handle.cc b/content/public/browser/navigation_handle.cc
index ec0099b2b42e1ad788940683549ce661ae670235..75f8e887f6d540a6891aca768e3374071744451b 100644
--- a/content/public/browser/navigation_handle.cc
+++ b/content/public/browser/navigation_handle.cc
@@ -27,16 +27,18 @@ NavigationHandle::CreateNavigationHandleForTesting(
RenderFrameHost* render_frame_host,
bool committed,
net::Error error) {
+ std::vector<GURL> redirect_chain;
+ redirect_chain.push_back(url);
+ RenderFrameHostImpl* rfhi =
+ static_cast<RenderFrameHostImpl*>(render_frame_host);
std::unique_ptr<NavigationHandleImpl> handle_impl =
NavigationHandleImpl::Create(
- url, static_cast<RenderFrameHostImpl*>(render_frame_host)
- ->frame_tree_node(),
+ url, std::vector<GURL>(), rfhi->frame_tree_node(),
true, // is_renderer_initiated
false, // is_same_page
base::TimeTicks::Now(), 0,
false); // started_from_context_menu
- handle_impl->set_render_frame_host(
- static_cast<RenderFrameHostImpl*>(render_frame_host));
+ handle_impl->set_render_frame_host(rfhi);
if (error != net::OK)
handle_impl->set_net_error_code(error);
if (committed)

Powered by Google App Engine
This is Rietveld 408576698