Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2657323003: Convert HistoryTabHelper to use the new navigation callbacks. (Closed)
Patch Set: better fix to send this data from the renderer initially Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 153be328985bbcec83b244a096998778cc72d4a5..a8c6807d347ded51b24046c3584f386d3d8dfc10 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -176,6 +176,14 @@ class CONTENT_EXPORT NavigationHandle {
// GetNetErrorCode will be net::OK.
virtual bool IsErrorPage() = 0;
+ // True if the committed entry has replaced the existing one. A non-user
+ // initiated redirect causes such replacement.
+ virtual bool DidReplaceEntry() = 0;
+
+ // Returns true if the browser history should be updated. Otherwise only
+ // the session history will be updated. E.g., on unreachable urls.
+ virtual bool ShouldUpdateHistory() = 0;
+
// Returns the response headers for the request, or nullptr if there aren't
// any response headers or they have not been received yet. The response
// headers may change during the navigation (e.g. after encountering a server

Powered by Google App Engine
This is Rietveld 408576698