Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2657313002:
Convert DevToolsUIBindingsEnabler to use the new navigation callbacks. (Closed)
DescriptionConvert DevToolsUIBindingsEnabler to use the new navigation callbacks.
BUG=682002
Review-Url: https://codereview.chromium.org/2657313002
Cr-Commit-Position: refs/heads/master@{#446823}
Committed: https://chromium.googlesource.com/chromium/src/+/edcc6272584a2bd337ad4e3540b62788e6509dff
Patch Set 1 #Patch Set 2 : a #Messages
Total messages: 19 (15 generated)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Description was changed from ========== Convert DevToolsUIBindingsEnabler to use the new navigation callbacks. BUG=682002 ========== to ========== Convert DevToolsUIBindingsEnabler to use the new navigation callbacks. BUG=682002 ==========
jam@chromium.org changed reviewers: + dgozman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485558303889470,
"parent_rev": "1d7952b5568f9777eb038d5101269aead6b071f2", "commit_rev":
"edcc6272584a2bd337ad4e3540b62788e6509dff"}
Message was sent while issue was closed.
Description was changed from ========== Convert DevToolsUIBindingsEnabler to use the new navigation callbacks. BUG=682002 ========== to ========== Convert DevToolsUIBindingsEnabler to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2657313002 Cr-Commit-Position: refs/heads/master@{#446823} Committed: https://chromium.googlesource.com/chromium/src/+/edcc6272584a2bd337ad4e3540b6... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/edcc6272584a2bd337ad4e3540b6... |
