[cipd] Add subdir support to deployer.

[cipd] Add subdir support to deployer.

Still not exposed via CLI, but now the deployer knows how to install to
various subdirectories.

R=vadimsh@chromium.org
BUG=663843
Review-Url: https://codereview.chromium.org/2657293005
Committed: https://github.com/luci/luci-go/commit/d8d9d690d8c75ddbe50e0bdb2734ab6b49e4a4cf

[iannucci, 2017-01-28 01:15:09]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 01:15:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 01:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 01:27:24]

Dry run: Try jobs failed on following builders:
  Luci-go Win Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/33fb7b7fbd6c8610)

[Vadim Sh., 2017-01-28 01:50:12]

lgtm

https://codereview.chromium.org/2657293005/diff/1/cipd/client/cipd/local/depl...
File cipd/client/cipd/local/deployer.go (right):

https://codereview.chromium.org/2657293005/diff/1/cipd/client/cipd/local/depl...
cipd/client/cipd/local/deployer.go:48: // packages and installing new ones will
reuse the smallest ones).
hm... this may be a problem if some updates fail mid-way: they can leave a
garbage in the site root, symlinking to .pkgs/<index> (and if <index> is reused,
they may start point to something unexpected).

https://codereview.chromium.org/2657293005/diff/1/cipd/client/cipd/local/depl...
cipd/client/cipd/local/deployer.go:421: rel :=
filepath.Join(filepath.FromSlash(packagesDir))
er... why do we do filepath.Join here?

https://codereview.chromium.org/2657293005/diff/1/cipd/client/cipd/local/depl...
cipd/client/cipd/local/deployer.go:462: tmpDir, err := d.TempDir(ctx,
strings.Replace(pkg, "/", "_", -1))
using 'pkg' here can be a problem on windows. We formally do not restrict length
of package names (e.g. one can have
really/long/package/name/in/cipd/repository/and/it/should/work/windows-amd64).

https://codereview.chromium.org/2657293005/diff/1/cipd/client/cipd/local/depl...
cipd/client/cipd/local/deployer.go:706: fmt.Printf("wat: %q, %q, %q\n", subdir,
files[0].Name, absPath)
wat? :)

[iannucci, 2017-01-30 02:05:12]

https://codereview.chromium.org/2657293005/diff/1/cipd/client/cipd/local/depl...
File cipd/client/cipd/local/deployer.go (right):

https://codereview.chromium.org/2657293005/diff/1/cipd/client/cipd/local/depl...
cipd/client/cipd/local/deployer.go:48: // packages and installing new ones will
reuse the smallest ones).
On 2017/01/28 01:50:12, Vadim Sh. wrote:
> hm... this may be a problem if some updates fail mid-way: they can leave a
> garbage in the site root, symlinking to .pkgs/<index> (and if <index> is
reused,
> they may start point to something unexpected).

I don't think so, actually. Every index folder is created already-containing a
description.json. This means that a given numbered folder may only be used for a
single subdir+package (regardless of which client sees that folder. If a
different client/later client attempted to re-use the folder, it would only
re-use it for the same subdir+package combination (assuming no bugs in the
packageName function).

[iannucci, 2017-01-30 22:05:43]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2017-01-30 22:05:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-01-30 22:06:19]

The CQ bit was unchecked by iannucci@chromium.org

[iannucci, 2017-01-30 22:06:31]

On 2017/01/30 22:05:49, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

oops, didn't mean to commit this one quite yet (I think)

[iannucci, 2017-01-31 01:08:42]

https://codereview.chromium.org/2657293005/diff/1/cipd/client/cipd/local/depl...
File cipd/client/cipd/local/deployer.go (right):

https://codereview.chromium.org/2657293005/diff/1/cipd/client/cipd/local/depl...
cipd/client/cipd/local/deployer.go:421: rel :=
filepath.Join(filepath.FromSlash(packagesDir))
On 2017/01/28 01:50:12, Vadim Sh. wrote:
> er... why do we do filepath.Join here?

dunno!

https://codereview.chromium.org/2657293005/diff/1/cipd/client/cipd/local/depl...
cipd/client/cipd/local/deployer.go:462: tmpDir, err := d.TempDir(ctx,
strings.Replace(pkg, "/", "_", -1))
On 2017/01/28 01:50:12, Vadim Sh. wrote:
> using 'pkg' here can be a problem on windows. We formally do not restrict
length
> of package names (e.g. one can have
> really/long/package/name/in/cipd/repository/and/it/should/work/windows-amd64).

done, I have it take the last two components now.

https://codereview.chromium.org/2657293005/diff/1/cipd/client/cipd/local/depl...
cipd/client/cipd/local/deployer.go:706: fmt.Printf("wat: %q, %q, %q\n", subdir,
files[0].Name, absPath)
On 2017/01/28 01:50:12, Vadim Sh. wrote:
> wat? :)

:D

[iannucci, 2017-01-31 01:40:09]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-01-31 01:40:09]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2657293005/#ps60001
(title: "fix tests")

[commit-bot: I haz the power, 2017-01-31 01:40:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 01:46:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485826809184170,
"parent_rev": "a2b77d3c5d27511cf5b7b08f19decb76b4cdc099", "commit_rev":
"d8d9d690d8c75ddbe50e0bdb2734ab6b49e4a4cf"}

[commit-bot: I haz the power, 2017-01-31 01:46:20]

Description was changed from

==========
[cipd] Add subdir support to deployer.

Still not exposed via CLI, but now the deployer knows how to install to
various subdirectories.

R=vadimsh@chromium.org
BUG=663843
==========

to

==========
[cipd] Add subdir support to deployer.

Still not exposed via CLI, but now the deployer knows how to install to
various subdirectories.

R=vadimsh@chromium.org
BUG=663843

Review-Url: https://codereview.chromium.org/2657293005
Committed:
https://github.com/luci/luci-go/commit/d8d9d690d8c75ddbe50e0bdb2734ab6b49e4a4cf
==========

[commit-bot: I haz the power, 2017-01-31 01:46:21]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-go/commit/d8d9d690d8c75ddbe50e0bdb2734ab6b49e4a4cf