Modified service to include current native zone memory consumption information in the VM object. Ad…

Modified service to include current native zone memory consumption information in the VM object. Added a field to display this new information on the main page of the Observatory.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/b00df4d4ac364672924ae63d6d46a8b06db58261

[bkonyi, 2017-01-27 17:48:10]

bkonyi@google.com changed reviewers:
+ asiva@google.com, johnmccutchan@google.com

[Cutch, 2017-01-31 17:15:23]

https://codereview.chromium.org/2657283004/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/vm_view.dart (right):

https://codereview.chromium.org/2657283004/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/vm_view.dart:192: ..text =
Utils.formatSize(_vm.nativeZoneMemoryUsage)
we usually keep the raw value as the title attribute

https://codereview.chromium.org/2657283004/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2657283004/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:950: nativeZoneMemoryUsage =
map['_nativeZoneMemoryUsage'];
if (map['_...']) != null) {
  nativeZoneMemoryUsage = map['_...'];
}

[bkonyi, 2017-01-31 21:13:06]

https://codereview.chromium.org/2657283004/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/vm_view.dart (right):

https://codereview.chromium.org/2657283004/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/vm_view.dart:192: ..text =
Utils.formatSize(_vm.nativeZoneMemoryUsage)
On 2017/01/31 17:15:23, Cutch wrote:
> we usually keep the raw value as the title attribute

Done.

https://codereview.chromium.org/2657283004/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2657283004/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:950: nativeZoneMemoryUsage =
map['_nativeZoneMemoryUsage'];
On 2017/01/31 17:15:23, Cutch wrote:
> if (map['_...']) != null) {
>   nativeZoneMemoryUsage = map['_...'];
> }

Done, but why is this check not done for other fields in the VM object?

[Cutch, 2017-01-31 21:20:08]

LGTM after offline discussion

[bkonyi, 2017-01-31 21:26:10]

Description was changed from

==========
Modified service to include current native zone memory consumption information
in the VM object. Added a field to display this new information on the main page
of the Observatory.

BUG=
==========

to

==========
Modified service to include current native zone memory consumption information
in the VM object. Added a field to display this new information on the main page
of the Observatory.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b00df4d4ac364672924ae63d6d46a8b06db58261
==========

[bkonyi, 2017-01-31 21:26:12]

Committed patchset #2 (id:20001) manually as
b00df4d4ac364672924ae63d6d46a8b06db58261 (presubmit successful).