Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: runtime/observatory/lib/src/service/object.dart

Issue 2657283004: Modified service to include current native zone memory consumption information in the VM object. Ad… (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of service; 5 part of service;
6 6
7 // Some value smaller than the object ring, so requesting a large array 7 // Some value smaller than the object ring, so requesting a large array
8 // doesn't result in an expired ref because the elements lapped it in the 8 // doesn't result in an expired ref because the elements lapped it in the
9 // object ring. 9 // object ring.
10 const int kDefaultFieldLimit = 100; 10 const int kDefaultFieldLimit = 100;
(...skipping 641 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 652
653 // The list of live isolates, ordered by isolate start time. 653 // The list of live isolates, ordered by isolate start time.
654 final List<Isolate> isolates = <Isolate>[]; 654 final List<Isolate> isolates = <Isolate>[];
655 655
656 String version = 'unknown'; 656 String version = 'unknown';
657 String hostCPU; 657 String hostCPU;
658 String targetCPU; 658 String targetCPU;
659 int architectureBits; 659 int architectureBits;
660 bool assertsEnabled = false; 660 bool assertsEnabled = false;
661 bool typeChecksEnabled = false; 661 bool typeChecksEnabled = false;
662 int nativeZoneMemoryUsage = 0;
662 int pid = 0; 663 int pid = 0;
663 int maxRSS = 0; 664 int maxRSS = 0;
664 bool profileVM = false; 665 bool profileVM = false;
665 DateTime startTime; 666 DateTime startTime;
666 DateTime refreshTime; 667 DateTime refreshTime;
667 Duration get upTime { 668 Duration get upTime {
668 if (startTime == null) { 669 if (startTime == null) {
669 return null; 670 return null;
670 } 671 }
671 return (new DateTime.now().difference(startTime)); 672 return (new DateTime.now().difference(startTime));
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
939 _upgradeCollection(map, vm); 940 _upgradeCollection(map, vm);
940 941
941 _loaded = true; 942 _loaded = true;
942 version = map['version']; 943 version = map['version'];
943 hostCPU = map['hostCPU']; 944 hostCPU = map['hostCPU'];
944 targetCPU = map['targetCPU']; 945 targetCPU = map['targetCPU'];
945 architectureBits = map['architectureBits']; 946 architectureBits = map['architectureBits'];
946 int startTimeMillis = map['startTime']; 947 int startTimeMillis = map['startTime'];
947 startTime = new DateTime.fromMillisecondsSinceEpoch(startTimeMillis); 948 startTime = new DateTime.fromMillisecondsSinceEpoch(startTimeMillis);
948 refreshTime = new DateTime.now(); 949 refreshTime = new DateTime.now();
950 nativeZoneMemoryUsage = map['_nativeZoneMemoryUsage'];
Cutch 2017/01/31 17:15:23 if (map['_...']) != null) { nativeZoneMemoryUsag
bkonyi 2017/01/31 21:13:06 Done, but why is this check not done for other fie
949 pid = map['pid']; 951 pid = map['pid'];
950 maxRSS = map['_maxRSS']; 952 maxRSS = map['_maxRSS'];
951 profileVM = map['_profilerMode'] == 'VM'; 953 profileVM = map['_profilerMode'] == 'VM';
952 assertsEnabled = map['_assertsEnabled']; 954 assertsEnabled = map['_assertsEnabled'];
953 typeChecksEnabled = map['_typeChecksEnabled']; 955 typeChecksEnabled = map['_typeChecksEnabled'];
954 _removeDeadIsolates(map['isolates']); 956 _removeDeadIsolates(map['isolates']);
955 } 957 }
956 958
957 // Reload all isolates. 959 // Reload all isolates.
958 Future reloadIsolates() { 960 Future reloadIsolates() {
(...skipping 3558 matching lines...) Expand 10 before | Expand all | Expand 10 after
4517 var v = list[i]; 4519 var v = list[i];
4518 if ((v is Map) && _isServiceMap(v)) { 4520 if ((v is Map) && _isServiceMap(v)) {
4519 list[i] = owner.getFromMap(v); 4521 list[i] = owner.getFromMap(v);
4520 } else if (v is List) { 4522 } else if (v is List) {
4521 _upgradeList(v, owner); 4523 _upgradeList(v, owner);
4522 } else if (v is Map) { 4524 } else if (v is Map) {
4523 _upgradeMap(v, owner); 4525 _upgradeMap(v, owner);
4524 } 4526 }
4525 } 4527 }
4526 } 4528 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698