Revert "Revert "change SkColorTable to be immutable""

bench/RepeatTileBench.cpp

Index: bench/RepeatTileBench.cpp
diff --git a/bench/RepeatTileBench.cpp b/bench/RepeatTileBench.cpp
index c311c4af6cc4780648214ca17cd2a09143938513..c3a6102c729068cde4e178452ece9fdb959cd7b1 100644
--- a/bench/RepeatTileBench.cpp
+++ b/bench/RepeatTileBench.cpp
@@ -53,8 +53,8 @@ static uint8_t compute_666_index(SkPMColor c) {
 }
 
 static void convert_to_index666(const SkBitmap& src, SkBitmap* dst) {
-    SkColorTable* ctable = new SkColorTable(216);
-    SkPMColor* colors = ctable->lockColors();
+    SkPMColor storage[216];
+    SkPMColor* colors = storage;
     // rrr ggg bbb
     for (int r = 0; r < 6; r++) {
         int rr = conv_6_to_byte(r);
@@ -66,7 +66,7 @@ static void convert_to_index666(const SkBitmap& src, SkBitmap* dst) {
             }
         }
     }
-    ctable->unlockColors(true);
+    SkColorTable* ctable = new SkColorTable(storage, 216, kOpaque_SkAlphaType);

[scroggo, 2013/10/09 18:33:42]

We discussed in person, but for posterity:

This should respect the fIsOpaque field.

     dst->setConfig(SkBitmap::kIndex8_Config, src.width(), src.height());
     dst->allocPixels(ctable);
     ctable->unref();