Revert "Revert "change SkColorTable to be immutable""

bench/RepeatTileBench.cpp

 
 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include "SkBenchmark.h"
 #include "SkBitmap.h"
 #include "SkCanvas.h"
@@ skipping 35 matching lines @@
 
 static uint8_t compute_666_index(SkPMColor c) {
     int r = SkGetPackedR32(c);
     int g = SkGetPackedG32(c);
     int b = SkGetPackedB32(c);
 
     return conv_byte_to_6(r) * 36 + conv_byte_to_6(g) * 6 + conv_byte_to_6(b);
 }
 
 static void convert_to_index666(const SkBitmap& src, SkBitmap* dst) {
-    SkColorTable* ctable = new SkColorTable(216);
-    SkPMColor* colors = ctable->lockColors();
+    SkPMColor storage[216];
+    SkPMColor* colors = storage;
     // rrr ggg bbb
     for (int r = 0; r < 6; r++) {
         int rr = conv_6_to_byte(r);
         for (int g = 0; g < 6; g++) {
             int gg = conv_6_to_byte(g);
             for (int b = 0; b < 6; b++) {
                 int bb = conv_6_to_byte(b);
                 *colors++ = SkPreMultiplyARGB(0xFF, rr, gg, bb);
             }
         }
     }
-    ctable->unlockColors(true);
+    SkColorTable* ctable = new SkColorTable(storage, 216, kOpaque_SkAlphaType);

[scroggo, 2013/10/09 18:33:42]

We discussed in person, but for posterity:

This should respect the fIsOpaque field.

     dst->setConfig(SkBitmap::kIndex8_Config, src.width(), src.height());
     dst->allocPixels(ctable);
     ctable->unref();
 
     SkAutoLockPixels alps(src);
     SkAutoLockPixels alpd(*dst);
 
     for (int y = 0; y < src.height(); y++) {
         const SkPMColor* srcP = src.getAddr32(0, y);
         uint8_t* dstP = dst->getAddr8(0, y);
@@ skipping 60 matching lines @@
     }
 
 private:
     typedef SkBenchmark INHERITED;
 };
 
 DEF_BENCH(return new RepeatTileBench(SkBitmap::kARGB_8888_Config, true))
 DEF_BENCH(return new RepeatTileBench(SkBitmap::kARGB_8888_Config, false))
 DEF_BENCH(return new RepeatTileBench(SkBitmap::kRGB_565_Config))
 DEF_BENCH(return new RepeatTileBench(SkBitmap::kIndex8_Config))