Revert "Revert "change SkColorTable to be immutable""

Revert "Revert "change SkColorTable to be immutable""

This reverts commit b8162cb840f4cb6002ef68d5ac775c6a122c52a9.

Fixed was call-sites in benches that used the (now gone) setIsOpaque api.

R=scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11695

[reed1, 2013-10-09 17:25:09]

only change from original CL should be the two bench/ files

[scroggo, 2013-10-09 18:33:42]

https://codereview.chromium.org/26572006/diff/1/bench/RepeatTileBench.cpp
File bench/RepeatTileBench.cpp (right):

https://codereview.chromium.org/26572006/diff/1/bench/RepeatTileBench.cpp#new...
bench/RepeatTileBench.cpp:69: SkColorTable* ctable = new SkColorTable(storage,
216, kOpaque_SkAlphaType);
We discussed in person, but for posterity:

This should respect the fIsOpaque field.

[reed1, 2013-10-09 20:59:36]

ptal -- bitmapcopytest

[scroggo, 2013-10-09 21:13:55]

lgtm

https://codereview.chromium.org/26572006/diff/6001/bench/RepeatTileBench.cpp
File bench/RepeatTileBench.cpp (right):

https://codereview.chromium.org/26572006/diff/6001/bench/RepeatTileBench.cpp#...
bench/RepeatTileBench.cpp:69: SkColorTable* ctable = new SkColorTable(storage,
216, kPremul_SkAlphaType);
As discussed in person, this preserves the old, dumb behavior of the test, but
maybe we should go ahead and fix it?

[reed1, 2013-10-09 21:29:45]

https://codereview.chromium.org/26572006/diff/6001/bench/RepeatTileBench.cpp
File bench/RepeatTileBench.cpp (right):

https://codereview.chromium.org/26572006/diff/6001/bench/RepeatTileBench.cpp#...
bench/RepeatTileBench.cpp:69: SkColorTable* ctable = new SkColorTable(storage,
216, kPremul_SkAlphaType);
On 2013/10/09 21:13:55, scroggo wrote:
> As discussed in person, this preserves the old, dumb behavior of the test, but
> maybe we should go ahead and fix it?

Done.

[scroggo, 2013-10-09 21:30:18]

On 2013/10/09 21:29:45, reed1 wrote:
> https://codereview.chromium.org/26572006/diff/6001/bench/RepeatTileBench.cpp
> File bench/RepeatTileBench.cpp (right):
> 
>
https://codereview.chromium.org/26572006/diff/6001/bench/RepeatTileBench.cpp#...
> bench/RepeatTileBench.cpp:69: SkColorTable* ctable = new SkColorTable(storage,
> 216, kPremul_SkAlphaType);
> On 2013/10/09 21:13:55, scroggo wrote:
> > As discussed in person, this preserves the old, dumb behavior of the test,
but
> > maybe we should go ahead and fix it?
> 
> Done.

lgtm

[reed1, 2013-10-10 14:45:01]

Committed patchset #3 manually as r11695 (presubmit successful).