Enforcing that custom tag extensions have correct super classes.

Enforcing that custom tag extensions have correct super classes.

BUG=13448
R=vsm@google.com

Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1435

[vsm, 2013-10-14 18:25:32]

lgtm

Should we use the new API Siva is adding here?:
https://codereview.chromium.org/27140002/

https://codereview.chromium.org/26571005/diff/1/Source/bindings/dart/DartUtil...
File Source/bindings/dart/DartUtilities.cpp (right):

https://codereview.chromium.org/26571005/diff/1/Source/bindings/dart/DartUtil...
Source/bindings/dart/DartUtilities.cpp:411: if (Dart_IsError(result))
Move ASSERT into the if as ASSERT_NOT_REACHED?

[blois, 2013-10-14 19:24:06]

On 2013/10/14 18:25:32, vsm wrote:
> lgtm
> 
> Should we use the new API Siva is adding here?:
> https://codereview.chromium.org/27140002/
> 
>
https://codereview.chromium.org/26571005/diff/1/Source/bindings/dart/DartUtil...
> File Source/bindings/dart/DartUtilities.cpp (right):
> 
>
https://codereview.chromium.org/26571005/diff/1/Source/bindings/dart/DartUtil...
> Source/bindings/dart/DartUtilities.cpp:411: if (Dart_IsError(result))
> Move ASSERT into the if as ASSERT_NOT_REACHED?

Not sure that Siva's code can be used-
- This code is checking if the Type is a subclass of another Type, not instance
- It's creating an element to resolve the tag, so probably need to do the Dart
invoke anyways

Also, this is only at registration time (not upgrade), so shouldn't be a huge
perf hit.

[blois, 2013-10-14 19:24:13]

https://codereview.chromium.org/26571005/diff/1/Source/bindings/dart/DartUtil...
File Source/bindings/dart/DartUtilities.cpp (right):

https://codereview.chromium.org/26571005/diff/1/Source/bindings/dart/DartUtil...
Source/bindings/dart/DartUtilities.cpp:411: if (Dart_IsError(result))
On 2013/10/14 18:25:33, vsm wrote:
> Move ASSERT into the if as ASSERT_NOT_REACHED?

Done.

[blois, 2013-10-14 19:29:31]

Committed patchset #1 manually as r1435.