Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2657093004: [webnfc] Add an UMA histogram values for WebNFC API calls (Closed)

Created:
3 years, 10 months ago by shalamov
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[webnfc] Add an UMA histogram values for WebNFC API calls This CL adds histogram values for all functions that are exposed by the NFC interface https://w3c.github.io/web-nfc/#the-nfc-interface BUG=520391 Review-Url: https://codereview.chromium.org/2657093004 Cr-Commit-Position: refs/heads/master@{#447211} Committed: https://chromium.googlesource.com/chromium/src/+/5840bdfe2b13ae8ced1018b99662431188639bff

Patch Set 1 #

Patch Set 2 : Rebased to master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
shalamov
Please take a look.
3 years, 10 months ago (2017-01-30 08:15:32 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-01-30 08:21:18 UTC) #7
jwd
histograms lgtm
3 years, 10 months ago (2017-01-30 22:11:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657093004/1
3 years, 10 months ago (2017-01-31 06:56:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/146447)
3 years, 10 months ago (2017-01-31 06:58:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657093004/20001
3 years, 10 months ago (2017-01-31 09:13:02 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 09:17:45 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5840bdfe2b13ae8ced1018b99662...

Powered by Google App Engine
This is Rietveld 408576698