Populate a basic SystemProfileProto in UKM.

Populate a basic SystemProfileProto in UKM.

BUG=678682
Review-Url: https://codereview.chromium.org/2657083003
Cr-Commit-Position: refs/heads/master@{#447003}
Committed: https://chromium.googlesource.com/chromium/src/+/2b85c623d45e745e15ff65f10788c5d57f69ec3c

[rkaplow, 2017-01-27 00:40:49]

Description was changed from

==========
Populate a basic SystemProfileProto in UKM.

BUG=678682
==========

to

==========
Populate a basic SystemProfileProto in UKM.

BUG=678682
==========

[rkaplow, 2017-01-27 00:40:49]

rkaplow@chromium.org changed reviewers:
+ asvitkine@chromium.org, holte@chromium.org

[rkaplow, 2017-01-27 00:43:38]

let me know if you guys feel strongly about testing it more end-to-end
(presumably by deserializing from persisted)

[Steven Holte, 2017-01-27 03:01:53]

lgtm

[Alexei Svitkine (slow), 2017-01-27 17:32:25]

https://codereview.chromium.org/2657083003/diff/20001/components/ukm/ukm_serv...
File components/ukm/ukm_service.cc (right):

https://codereview.chromium.org/2657083003/diff/20001/components/ukm/ukm_serv...
components/ukm/ukm_service.cc:273: }
Can we share code with UMA?

I suggest we refactor the UMA code for filling out a SystemProfileProto into a
helper class or function and re-use that.

[rkaplow, 2017-01-27 21:08:18]

ok, PTAL.

It's not the exact same on the metrics side, we're recording some of the pieces
(os, etc.) earlier - not when we record the field trials, etc.

It still seems to be a bit arbitrary which fields move to the log init and which
get set later, but I wanted to keep the group that I wanted to put with UKM
together. This means I added a couple fields to UKM I didn't have before to make
the method a bit more consistant (ex. the ASAN bool).

[Alexei Svitkine (slow), 2017-01-27 21:11:56]

lgtm

https://codereview.chromium.org/2657083003/diff/60001/components/metrics/metr...
File components/metrics/metrics_log.h (right):

https://codereview.chromium.org/2657083003/diff/60001/components/metrics/metr...
components/metrics/metrics_log.h:77: static void
RecordCoreSystemProfile(MetricsServiceClient* client,
Nit: Comment.

[rkaplow, 2017-01-27 21:57:36]

https://codereview.chromium.org/2657083003/diff/60001/components/metrics/metr...
File components/metrics/metrics_log.h (right):

https://codereview.chromium.org/2657083003/diff/60001/components/metrics/metr...
components/metrics/metrics_log.h:77: static void
RecordCoreSystemProfile(MetricsServiceClient* client,
On 2017/01/27 21:11:56, Alexei Svitkine (slow) wrote:
> Nit: Comment.

Done.

[rkaplow, 2017-01-27 21:57:39]

The CQ bit was checked by rkaplow@chromium.org

[rkaplow, 2017-01-27 21:57:40]

The patchset sent to the CQ was uploaded after l-g-t-m from holte@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2657083003/#ps80001
(title: "add comment")

[commit-bot: I haz the power, 2017-01-27 21:58:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 22:23:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 22:23:46]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[rkaplow, 2017-01-27 22:41:44]

The CQ bit was checked by rkaplow@chromium.org

[rkaplow, 2017-01-27 22:41:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2657083003/#ps160001
(title: "fixing merge again again")

[commit-bot: I haz the power, 2017-01-27 22:42:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 23:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 23:15:51]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rkaplow, 2017-01-30 15:14:53]

The CQ bit was checked by rkaplow@chromium.org

[rkaplow, 2017-01-30 15:14:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2657083003/#ps180001
(title: "missing windows include")

[commit-bot: I haz the power, 2017-01-30 15:15:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 15:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 15:17:04]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[rkaplow, 2017-01-30 16:00:10]

The CQ bit was checked by rkaplow@chromium.org

[rkaplow, 2017-01-30 16:00:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2657083003/#ps220001
(title: "remove stale TODO")

[commit-bot: I haz the power, 2017-01-30 16:00:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 16:57:21]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1485792010482020,
"parent_rev": "5b8dedff45bd78f172028b56e50045caaca27715", "commit_rev":
"2b85c623d45e745e15ff65f10788c5d57f69ec3c"}

[commit-bot: I haz the power, 2017-01-30 16:57:59]

Description was changed from

==========
Populate a basic SystemProfileProto in UKM.

BUG=678682
==========

to

==========
Populate a basic SystemProfileProto in UKM.

BUG=678682

Review-Url: https://codereview.chromium.org/2657083003
Cr-Commit-Position: refs/heads/master@{#447003}
Committed:
https://chromium.googlesource.com/chromium/src/+/2b85c623d45e745e15ff65f10788...
==========

[commit-bot: I haz the power, 2017-01-30 16:58:00]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/2b85c623d45e745e15ff65f10788...