Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2657073005: Use grey_scrollViewContentOffset instead of custom written matcher. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
baxley
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use grey_scrollViewContentOffset instead of custom written matcher. BUG=651685 Review-Url: https://codereview.chromium.org/2657073005 Cr-Commit-Position: refs/heads/master@{#446803} Committed: https://chromium.googlesource.com/chromium/src/+/2003640a511edc63254aff621e7124df5cf9b333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -27 lines) Patch
M ios/web/shell/test/page_state_egtest.mm View 3 chunks +11 lines, -27 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-01-27 21:40:29 UTC) #6
baxley
lgtm
3 years, 10 months ago (2017-01-27 21:42:05 UTC) #7
Eugene But (OOO till 7-30)
Thanks for a quick review!
3 years, 10 months ago (2017-01-27 21:57:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657073005/1
3 years, 10 months ago (2017-01-27 21:59:05 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 22:43:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2003640a511edc63254aff621e71...

Powered by Google App Engine
This is Rietveld 408576698