Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2657053002: Add an mImplementationMap to ChromeApplication (Closed)

Created:
3 years, 11 months ago by cco3
Modified:
3 years, 10 months ago
Reviewers:
Maria
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an mImplementationMap to ChromeApplication This removes the need for a createObjectImpl method that needs to be implemented both upstream and downstream. BUG=685383 Review-Url: https://codereview.chromium.org/2657053002 Cr-Commit-Position: refs/heads/master@{#446794} Committed: https://chromium.googlesource.com/chromium/src/+/bf26a5aa18bcd875deed4af9e4c7995f701de3f9

Patch Set 1 #

Patch Set 2 : Fix small javadoc mistype #

Total comments: 2

Patch Set 3 : Use ArrayMap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 1 2 5 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
cco3
3 years, 11 months ago (2017-01-26 21:03:30 UTC) #2
Maria
https://codereview.chromium.org/2657053002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java (right): https://codereview.chromium.org/2657053002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java#newcode119 chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:119: mImplementationMap = new HashMap<Class, Class>(); See comment on map ...
3 years, 11 months ago (2017-01-27 04:39:55 UTC) #3
cco3
https://codereview.chromium.org/2657053002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java (right): https://codereview.chromium.org/2657053002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java#newcode119 chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:119: mImplementationMap = new HashMap<Class, Class>(); On 2017/01/27 04:39:55, Maria ...
3 years, 10 months ago (2017-01-27 17:52:35 UTC) #4
Maria
lgtm
3 years, 10 months ago (2017-01-27 17:59:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657053002/40001
3 years, 10 months ago (2017-01-27 21:24:08 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 22:29:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bf26a5aa18bcd875deed4af9e4c7...

Powered by Google App Engine
This is Rietveld 408576698