Convert AudioParam tests to testharness and new Audit

Convert AudioParam tests to testharness and new Audit

Manually convert all tests using createAudioGraphAndTest to use
testharness and new Audit.

BUG=685355
TEST=audioparam-exponentialRampToValueAtTime.html
audioparam-linearRampToValueAtTime.html
audioparam-setTargetAtTime.html
audioparam-setValueAtTime.html
audioparam-setValueCurveAtTime.html

Review-Url: https://codereview.chromium.org/2657033002
Cr-Commit-Position: refs/heads/master@{#447058}
Committed: https://chromium.googlesource.com/chromium/src/+/fa102cf589f1db56e94cd4fc2493d5c26b4c9c91

[Raymond Toy, 2017-01-27 19:23:10]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-01-27 19:23:11]

PTAL

[hongchan, 2017-01-30 17:38:04]

https://codereview.chromium.org/2657033002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js
(right):

https://codereview.chromium.org/2657033002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js:237:
//testFailed("NaN or infinity for rendered data at " + maxErrorIndex);
Remove this line.

https://codereview.chromium.org/2657033002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js:238:
should(!isValidNumber(rendered[startSample + k]),
Can this be |isValidNumber()| then |beTrue()|?

Same for l.247.

https://codereview.chromium.org/2657033002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js:246:
//testFailed("Nan or infinity for reference data at " + maxErrorIndex);
Ditto.

https://codereview.chromium.org/2657033002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js:365: /*
Remove commented line.

https://codereview.chromium.org/2657033002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js:380: /*
Ditto.

https://codereview.chromium.org/2657033002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js:392: /*
Ditto.

[Raymond Toy, 2017-01-30 18:07:03]

https://codereview.chromium.org/2657033002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js
(right):

https://codereview.chromium.org/2657033002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js:238:
should(!isValidNumber(rendered[startSample + k]),
On 2017/01/30 17:38:04, hongchan wrote:
> Can this be |isValidNumber()| then |beTrue()|?
> 
> Same for l.247.

I thought it would be better to keep the test condition be the same as the if in
line 234.  But I can reverse the test here if it's better.

[hongchan, 2017-01-30 18:34:58]

lgtm.

Can you apply clang-format before committing it?

[Raymond Toy, 2017-01-30 18:35:42]

On 2017/01/30 18:34:58, hongchan wrote:
> lgtm.
> 
> Can you apply clang-format before committing it?

That was the plan. :-)

[Raymond Toy, 2017-01-30 19:09:45]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-01-30 19:09:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2657033002/#ps60001
(title: "clang-format the JS code.")

[commit-bot: I haz the power, 2017-01-30 19:10:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 21:04:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485803385400250,
"parent_rev": "8576e703d22ac09c939415b9e7eb9cc0323b2ebe", "commit_rev":
"fa102cf589f1db56e94cd4fc2493d5c26b4c9c91"}

[commit-bot: I haz the power, 2017-01-30 21:05:13]

Description was changed from

==========
Convert AudioParam tests to testharness and new Audit

Manually convert all tests using createAudioGraphAndTest to use
testharness and new Audit.

BUG=685355
TEST=audioparam-exponentialRampToValueAtTime.html
audioparam-linearRampToValueAtTime.html
audioparam-setTargetAtTime.html
audioparam-setValueAtTime.html
audioparam-setValueCurveAtTime.html
==========

to

==========
Convert AudioParam tests to testharness and new Audit

Manually convert all tests using createAudioGraphAndTest to use
testharness and new Audit.

BUG=685355
TEST=audioparam-exponentialRampToValueAtTime.html
audioparam-linearRampToValueAtTime.html
audioparam-setTargetAtTime.html
audioparam-setValueAtTime.html
audioparam-setValueCurveAtTime.html

Review-Url: https://codereview.chromium.org/2657033002
Cr-Commit-Position: refs/heads/master@{#447058}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa102cf589f1db56e94cd4fc2493...
==========

[commit-bot: I haz the power, 2017-01-30 21:05:14]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fa102cf589f1db56e94cd4fc2493...