Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2657023005: [webnfc] Allow access to WebNFC API only from main frame (Closed)

Created:
3 years, 10 months ago by shalamov
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[webnfc] Allow access to WebNFC API only from main frame This CL adds functionality that checks whether browsing context is a main frame (top-level browsing context) as specified in https://w3c.github.io/web-nfc/#security-policies New layout test is added to verify new functionality. - third_party/WebKit/LayoutTests/nfc/nfc-block-iframe.html BUG=520391 Review-Url: https://codereview.chromium.org/2657023005 Cr-Commit-Position: refs/heads/master@{#447729} Committed: https://chromium.googlesource.com/chromium/src/+/6eef82663dd4619c7ea75db5bac1e87f37b64046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/nfc/nfc-block-iframe.html View 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/nfc/resources/nfc-helpers.js View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/nfc/resources/push-from-iframe.html View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
shalamov
PTAL
3 years, 10 months ago (2017-01-30 08:13:18 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-01-30 08:19:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657023005/1
3 years, 10 months ago (2017-02-02 07:33:54 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 08:46:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6eef82663dd4619c7ea75db5bac1...

Powered by Google App Engine
This is Rietveld 408576698