components/sync/driver/sync_stopped_reporter.h - Issue 2657013002: Introduce ThreadTaskRunnerHandle::OverrideForTesting and TestMockTimeTaskRunner::ScopedContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/sync_stopped_reporter.h

Issue 2657013002: Introduce ThreadTaskRunnerHandle::OverrideForTesting and TestMockTimeTaskRunner::ScopedContext. (Closed)

Patch Set: fix task runner paradigms in SyncStoppedReporterTest and ServerBackedStateKeysBrokerTest Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/sync_stopped_reporter.h

diff --git a/components/sync/driver/sync_stopped_reporter.h b/components/sync/driver/sync_stopped_reporter.h

index dfb5c0ec7d72f5543dde3f614b0ed9bfaa472ad5..a7194f6de92519b0fe815f630953b49aff6b11ad 100644

--- a/components/sync/driver/sync_stopped_reporter.h

+++ b/components/sync/driver/sync_stopped_reporter.h

@@ -43,10 +43,6 @@ class SyncStoppedReporter : public net::URLFetcherDelegate {

// net::URLFetcherDelegate implementation.

void OnURLFetchComplete(const net::URLFetcher* source) override;

- // Override the timer's task runner so it can be triggered in tests.

- void SetTimerTaskRunnerForTest(

- const scoped_refptr<base::SingleThreadTaskRunner>& task_runner);

private:

// Convert the base sync URL into the sync event URL.

static GURL GetSyncEventURL(const GURL& sync_service_url);