chrome/browser/chromeos/policy/server_backed_state_keys_broker_unittest.cc - Issue 2657013002: Introduce ThreadTaskRunnerHandle::OverrideForTesting and TestMockTimeTaskRunner::ScopedContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/server_backed_state_keys_broker_unittest.cc

Issue 2657013002: Introduce ThreadTaskRunnerHandle::OverrideForTesting and TestMockTimeTaskRunner::ScopedContext. (Closed)

Patch Set: fix task runner paradigms in SyncStoppedReporterTest and ServerBackedStateKeysBrokerTest Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/threading/thread_task_runner_handle.cc ('k') | components/sync/driver/sync_stopped_reporter.h » ('j') | net/http/http_server_properties_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/server_backed_state_keys_broker_unittest.cc

diff --git a/chrome/browser/chromeos/policy/server_backed_state_keys_broker_unittest.cc b/chrome/browser/chromeos/policy/server_backed_state_keys_broker_unittest.cc

index 30c4c8f6f312d848d9dc13e89e9cff80d0f96236..b4b8ac7dd726cdc3e50c4112ccd0a2a91350e944 100644

--- a/chrome/browser/chromeos/policy/server_backed_state_keys_broker_unittest.cc

+++ b/chrome/browser/chromeos/policy/server_backed_state_keys_broker_unittest.cc

@@ -113,15 +113,13 @@ TEST_F(ServerBackedStateKeysBrokerTest, Refresh) {

state_keys_.push_back("4");

fake_session_manager_client_.set_server_backed_state_keys(state_keys_);

updated_ = false;

- task_runner_->RunPendingTasks();

- base::RunLoop().RunUntilIdle();

+ task_runner_->RunUntilIdle();

EXPECT_TRUE(updated_);

ExpectGood();

// No update callback if the keys are unchanged.

updated_ = false;

- task_runner_->RunPendingTasks();

- base::RunLoop().RunUntilIdle();

+ task_runner_->RunUntilIdle();

EXPECT_FALSE(updated_);

ExpectGood();

}