Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2657003004: aura-mus: Hook up PerformWindowMove(). (Closed)

Created:
3 years, 11 months ago by Elliot Glaysher
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aura-mus: Hook up PerformWindowMove(). We can now drag tabs out and dock them on the side again. BUG=663527 Review-Url: https://codereview.chromium.org/2657003004 Cr-Commit-Position: refs/heads/master@{#446757} Committed: https://chromium.googlesource.com/chromium/src/+/67981c6373076a89183211bf23b741101503672f

Patch Set 1 #

Patch Set 2 : Add comments. #

Total comments: 2

Patch Set 3 : Fold PerformWindowMove and CancelWindowMove. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -34 lines) Patch
M ui/aura/mus/window_tree_client.h View 1 2 2 chunks +7 lines, -11 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 2 2 chunks +22 lines, -20 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus.h View 2 chunks +11 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus_delegate.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.cc View 3 chunks +33 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Elliot Glaysher
The ws side tests are still there. But the entire client side RunMoveLoop() code doesn't ...
3 years, 10 months ago (2017-01-27 18:47:13 UTC) #8
sky
https://codereview.chromium.org/2657003004/diff/20001/ui/aura/mus/window_tree_client.cc File ui/aura/mus/window_tree_client.cc (right): https://codereview.chromium.org/2657003004/diff/20001/ui/aura/mus/window_tree_client.cc#newcode1718 ui/aura/mus/window_tree_client.cc:1718: PerformWindowMove(window_tree_host->window(), Is there any reason to keep the PerformWindowMove/CAncelWindowMove ...
3 years, 10 months ago (2017-01-27 19:00:31 UTC) #9
Elliot Glaysher
https://codereview.chromium.org/2657003004/diff/20001/ui/aura/mus/window_tree_client.cc File ui/aura/mus/window_tree_client.cc (right): https://codereview.chromium.org/2657003004/diff/20001/ui/aura/mus/window_tree_client.cc#newcode1718 ui/aura/mus/window_tree_client.cc:1718: PerformWindowMove(window_tree_host->window(), On 2017/01/27 19:00:31, sky wrote: > Is there ...
3 years, 10 months ago (2017-01-27 20:22:16 UTC) #14
sky
LGTM
3 years, 10 months ago (2017-01-27 20:26:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657003004/40001
3 years, 10 months ago (2017-01-27 20:39:08 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 20:44:56 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/67981c6373076a89183211bf23b7...

Powered by Google App Engine
This is Rietveld 408576698