Report ONLINE for the Active Directory devices

Report ONLINE for the Active Directory devices

Even if there is no connection to the internet.  These devices does not
have to be online to reach the server

BUG=684615
TEST=manual

Review-Url: https://codereview.chromium.org/2657003002
Cr-Commit-Position: refs/heads/master@{#448941}
Committed: https://chromium.googlesource.com/chromium/src/+/c72cae2cb4d649182cf25a4751b43df55230ff04

[Roman Sorokin (ftl), 2017-01-26 17:59:29]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 17:59:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-01-26 18:01:05]

rsorokin@chromium.org changed reviewers:
+ achuith@chromium.org

[Roman Sorokin (ftl), 2017-01-26 18:01:05]

Achuith, could you PTAL? Thanks!

[commit-bot: I haz the power, 2017-01-26 18:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 18:29:40]

Dry run: This issue passed the CQ dry run.

[achuithb, 2017-01-27 01:05:02]

I don't understand this CL - are you reporting AD always being online to
suppress dinosaur?

[Roman Sorokin (ftl), 2017-01-27 09:51:08]

On 2017/01/27 01:05:02, achuithb wrote:
> I don't understand this CL - are you reporting AD always being online to
> suppress dinosaur?

Thiemo actually meant offline screen (which has dinosaur on it). So this
suppress the screen, cause AD devices does not have to be online.

[achuithb, 2017-01-27 10:25:24]

On 2017/01/27 09:51:08, Roman Sorokin wrote:
> On 2017/01/27 01:05:02, achuithb wrote:
> > I don't understand this CL - are you reporting AD always being online to
> > suppress dinosaur?
> 
> Thiemo actually meant offline screen (which has dinosaur on it). So this
> suppress the screen, cause AD devices does not have to be online.

Isn't this a hacky way to do it? Shouldn't you put this logic in the place where
we make the decision to show the dinosaur screen, instead of pretending to be
online?

[Roman Sorokin (ftl), 2017-01-27 13:27:33]

On 2017/01/27 10:25:24, achuithb wrote:
> On 2017/01/27 09:51:08, Roman Sorokin wrote:
> > On 2017/01/27 01:05:02, achuithb wrote:
> > > I don't understand this CL - are you reporting AD always being online to
> > > suppress dinosaur?
> > 
> > Thiemo actually meant offline screen (which has dinosaur on it). So this
> > suppress the screen, cause AD devices does not have to be online.
> 
> Isn't this a hacky way to do it? Shouldn't you put this logic in the place
where
> we make the decision to show the dinosaur screen, instead of pretending to be
> online?

Kinda, but the thing is when there is no network at all we still wanna to report
offline. And when we show offline screen there is no distinction between "no
network" and "network with no connection to the internet". Both reported as
OFFLINE. So I report ONLINE only in case there is some network connected and
it's AD device.

[achuithb, 2017-02-07 20:14:23]

lgtm

[Roman Sorokin (ftl), 2017-02-08 09:42:01]

The CQ bit was checked by rsorokin@chromium.org

[commit-bot: I haz the power, 2017-02-08 09:42:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 10:11:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486546921331100, "parent_rev":
"29fc3042b1b3bea3e71a2c5b0a9a81ce435c2d39", "commit_rev":
"c72cae2cb4d649182cf25a4751b43df55230ff04"}

[commit-bot: I haz the power, 2017-02-08 10:11:51]

Description was changed from

==========
Report ONLINE for the Active Directory devices

Even if there is no connection to the internet.  These devices does not
have to be online to reach the server

BUG=684615
TEST=manual
==========

to

==========
Report ONLINE for the Active Directory devices

Even if there is no connection to the internet.  These devices does not
have to be online to reach the server

BUG=684615
TEST=manual

Review-Url: https://codereview.chromium.org/2657003002
Cr-Commit-Position: refs/heads/master@{#448941}
Committed:
https://chromium.googlesource.com/chromium/src/+/c72cae2cb4d649182cf25a4751b4...
==========

[commit-bot: I haz the power, 2017-02-08 10:11:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c72cae2cb4d649182cf25a4751b4...