third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt - Issue 2656993002: Throw TypeError instead of InvalidAccessError for invalid times

Unified Diff: third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt

Issue 2656993002: Throw TypeError instead of InvalidAccessError for invalid times (Closed)

Patch Set: Address review comments and clang-format it Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html ('k') | third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt

diff --git a/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt b/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt

index de0c2a79e3a9ac2c62f3197a4bf81b67b06f0049..1641d407e1d5a983ae26d7a03396643335e59060 100644

--- a/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt

+++ b/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt

@@ -105,10 +105,10 @@ PASS < [channel-stuff] All assertions passed. (total 7 assertions)

PASS > [audioparam]

PASS param.setValueCurveAtTime(null, 0, 0) threw TypeError: "Failed to execute 'setValueCurveAtTime' on 'AudioParam': The provided value cannot be converted to a sequence.".

PASS node.gain.exponentialRampToValueAtTime(-1, 0.1) did not throw an exception.

-PASS node.gain.exponentialRampToValueAtTime(0, 0.1) threw InvalidAccessError: "Failed to execute 'exponentialRampToValueAtTime' on 'AudioParam': The float target value provided (0) should not be in the range (-1.40130e-45, 1.40130e-45).".

-PASS node.gain.exponentialRampToValueAtTime(1e-100, 0.1) threw InvalidAccessError: "Failed to execute 'exponentialRampToValueAtTime' on 'AudioParam': The float target value provided (0) should not be in the range (-1.40130e-45, 1.40130e-45).".

+PASS node.gain.exponentialRampToValueAtTime(0, 0.1) threw RangeError: "Failed to execute 'exponentialRampToValueAtTime' on 'AudioParam': The float target value provided (0) should not be in the range (-1.40130e-45, 1.40130e-45).".

+PASS node.gain.exponentialRampToValueAtTime(1e-100, 0.1) threw RangeError: "Failed to execute 'exponentialRampToValueAtTime' on 'AudioParam': The float target value provided (0) should not be in the range (-1.40130e-45, 1.40130e-45).".

PASS node.gain.exponentialRampToValueAtTime(Math.pow(2, -149), 0.1) did not throw an exception.

-PASS node.gain.exponentialRampToValueAtTime(Math.pow(2, -150), 0.1) threw InvalidAccessError: "Failed to execute 'exponentialRampToValueAtTime' on 'AudioParam': The float target value provided (0) should not be in the range (-1.40130e-45, 1.40130e-45).".

+PASS node.gain.exponentialRampToValueAtTime(Math.pow(2, -150), 0.1) threw RangeError: "Failed to execute 'exponentialRampToValueAtTime' on 'AudioParam': The float target value provided (0) should not be in the range (-1.40130e-45, 1.40130e-45).".

PASS < [audioparam] All assertions passed. (total 6 assertions)

PASS > [biquad]

PASS node.getFrequencyResponse(new Float32Array(1), new Float32Array(1), new Float32Array(1)) did not throw an exception.