third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html - Issue 2656993002: Throw TypeError instead of InvalidAccessError for invalid times

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html

Issue 2656993002: Throw TypeError instead of InvalidAccessError for invalid times (Closed)

Patch Set: Address review comments and clang-format it Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html ('k') | third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html

index 3eef32f1e0e2296042a909e2c20da25d7bfd146b..00f0dcec2d3b954a5825ef33ace13a09323f5a0f 100644

--- a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html

+++ b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html

@@ -68,7 +68,7 @@

.linearRampToValueAtTime(2.0, 1.0);

'Calling setValueAtTime() with a negative end time')

- .throw('InvalidAccessError');

+ .throw('RangeError');

// The first operation succeeds but the second fails due to zero target

// value for the exponential ramp. Thus only the first should have

@@ -79,7 +79,7 @@

0.0, 1.0);

'Calling exponentialRampToValueAtTime() with a zero target value')

- .throw('InvalidAccessError');

+ .throw('RangeError');

osc.start();

osc.stop(1.0);