tools/gn/trace.cc - Issue 265693003: Redo GN "args" command

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/trace.cc

Issue 265693003: Redo GN "args" command (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/trace.cc

diff --git a/tools/gn/trace.cc b/tools/gn/trace.cc

index acd735df365cef7707c9cf18c3efc6e29d5d1328..4dfb6ca2c07a3965fb487ade02da1ecf8df02162 100644

--- a/tools/gn/trace.cc

+++ b/tools/gn/trace.cc

@@ -167,8 +167,8 @@ void ScopedTrace::Done() {

}

void EnableTracing() {

- CHECK(!trace_log);

- trace_log = new TraceLog;

+ if (!trace_log)

+ trace_log = new TraceLog;

}

void AddTrace(TraceItem* item) {

@@ -204,6 +204,7 @@ std::string SummarizeTraces() {

case TraceItem::TRACE_CHECK_HEADER:

headers_checked++;

break;

+ case TraceItem::TRACE_SETUP:

case TraceItem::TRACE_FILE_LOAD:

case TraceItem::TRACE_FILE_WRITE:

case TraceItem::TRACE_DEFINE_TARGET:

@@ -265,6 +266,9 @@ void SaveTraces(const base::FilePath& file_name) {

out << ",\"cat\":";

switch (item.type()) {

+ case TraceItem::TRACE_SETUP:

+ out << "\"setup\"";

+ break;

case TraceItem::TRACE_FILE_LOAD:

out << "\"load\"";

break;