Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/escape_unittest.cc

Issue 265693003: Redo GN "args" command (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/command_args.cc ('K') | « tools/gn/command_args.cc ('k') | tools/gn/gn.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/escape_unittest.cc
diff --git a/tools/gn/escape_unittest.cc b/tools/gn/escape_unittest.cc
index 44440de6e91a065c25d99178c8841c5084a7b040..7ba0af060d18099de347dee1297c86a5c35ba700 100644
--- a/tools/gn/escape_unittest.cc
+++ b/tools/gn/escape_unittest.cc
@@ -17,8 +17,9 @@ TEST(Escape, Shell) {
opts.mode = ESCAPE_SHELL;
std::string result = EscapeString("asdf: \"$\\bar", opts, NULL);
#if defined(OS_WIN)
- // Windows shell doesn't escape backslashes.
- EXPECT_EQ("\"asdf: \"$\\bar\"", result);
+ // Windows shell doesn't escape backslashes, but it does backslash-escape
+ // quotes.
+ EXPECT_EQ("\"asdf: \\\"$\\bar\"", result);
#else
EXPECT_EQ("\"asdf: \\\"$\\\\bar\"", result);
#endif
« tools/gn/command_args.cc ('K') | « tools/gn/command_args.cc ('k') | tools/gn/gn.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698