Issue 2656903004: Fixed issue where initial 1KB zone buffer was not being accounted for when tracking thread zone mem…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2656903004: Fixed issue where initial 1KB zone buffer was not being accounted for when tracking thread zone mem… (Closed)

Created:
3 years, 11 months ago by bkonyi

Modified:
3 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fixed issue where initial 1KB zone buffer was not being accounted for when tracking thread zone memory usage. Add debug step check before break and continue This allows debuggers to set a breakpoint in a line that contains a break or continue statement. When running dart2js on a small program, this adds around 900 DebugStepCheck runtime calls. I’m not sure the price is worth paying. BUG=#28473 R=asiva@google.com Review-Url: https://codereview.chromium.org/2651263002 .

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+26 lines, -2 lines)			Patch
runtime/vm/flow_graph_builder.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
runtime/vm/thread.cc	View	2 chunks	+13 lines, -2 lines	0 comments	Download
runtime/vm/zone.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2654983002 Patch 1