Add debug step check before break and continue

Add debug step check before break and continue

This allows debuggers to set a breakpoint in a line that contains
a break or continue statement.

When running dart2js on a small program, this adds around 900 DebugStepCheck
runtime calls. I’m not sure the price is worth paying.

BUG=#28473
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/cc8139350d1afa0410dd75a27f685877e106cf03

[hausner, 2017-01-25 20:31:10]

Description was changed from

==========
Add debug step check before break and continue

This allows debuggers to set a breakpoint in a line that contains
a break or continue statement.

When running dart2js on a small program, this adds around 900 DebugStepCheck
runtime calls. I’m not sure the price is worth paying.

BUG=#28473
==========

to

==========
Add debug step check before break and continue

This allows debuggers to set a breakpoint in a line that contains
a break or continue statement.

When running dart2js on a small program, this adds around 900 DebugStepCheck
runtime calls. I’m not sure the price is worth paying.

BUG=#28473
==========

[hausner, 2017-01-25 20:31:10]

hausner@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-01-26 17:07:59]

Does have a noticeable effect on the performance of dart2js

[hausner, 2017-01-26 18:19:54]

There is no measurable runtime regression. The main overhead is the additional
code that is generated.

[siva, 2017-01-26 21:32:46]

lgtm

[hausner, 2017-01-26 21:49:42]

Description was changed from

==========
Add debug step check before break and continue

This allows debuggers to set a breakpoint in a line that contains
a break or continue statement.

When running dart2js on a small program, this adds around 900 DebugStepCheck
runtime calls. I’m not sure the price is worth paying.

BUG=#28473
==========

to

==========
Add debug step check before break and continue

This allows debuggers to set a breakpoint in a line that contains
a break or continue statement.

When running dart2js on a small program, this adds around 900 DebugStepCheck
runtime calls. I’m not sure the price is worth paying.

BUG=#28473
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cc8139350d1afa0410dd75a27f685877e106cf03
==========

[hausner, 2017-01-26 21:49:43]

Committed patchset #1 (id:1) manually as
cc8139350d1afa0410dd75a27f685877e106cf03 (presubmit successful).