Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2656903003: PrintFixedArrayElements should avoid peeking into empty arrays. (Closed)

Created:
3 years, 11 months ago by mvstanton
Modified:
3 years, 11 months ago
Reviewers:
Tobias Tebbi
CC:
v8-reviews_googlegroups.com, Camillo Bruni
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PrintFixedArrayElements should avoid peeking into empty arrays. Small bugfix. BUG= Review-Url: https://codereview.chromium.org/2656903003 Cr-Commit-Position: refs/heads/master@{#42690} Committed: https://chromium.googlesource.com/v8/v8/+/76850146bf01e69ee3cb2952483bdb2c3e45c57d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
mvstanton
Hi Tobias, I just stumbled on this, could you have a look? Thanks! --Michael
3 years, 11 months ago (2017-01-26 10:00:29 UTC) #2
Tobias Tebbi
On 2017/01/26 10:00:29, mvstanton wrote: > Hi Tobias, I just stumbled on this, could you ...
3 years, 11 months ago (2017-01-26 11:42:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656903003/1
3 years, 11 months ago (2017-01-26 12:04:18 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 12:06:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/76850146bf01e69ee3cb2952483bdb2c3e4...

Powered by Google App Engine
This is Rietveld 408576698