Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2656903002: Move test_importer -> test_copier, deps_updater -> test_importer. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move test_importer -> test_copier, deps_updater -> test_importer. BUG=681406 Review-Url: https://codereview.chromium.org/2656903002 Cr-Commit-Position: refs/heads/master@{#446198} Committed: https://chromium.googlesource.com/chromium/src/+/22d3bc7d75a5f9180bca7860ee23c3f731607eda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+573 lines, -1106 lines) Patch
D third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +0 lines, -460 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 1 chunk +0 lines, -151 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier_unittest.py View 6 chunks +35 lines, -35 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 chunk +407 lines, -303 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 1 chunk +126 lines, -152 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/wpt-import View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qyearsley
Does "TestCopier" seem like an OK name? Any other ideas?
3 years, 11 months ago (2017-01-25 22:07:58 UTC) #2
jeffcarp
lgtm
3 years, 11 months ago (2017-01-26 00:07:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656903002/1
3 years, 11 months ago (2017-01-26 00:34:15 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 01:44:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/22d3bc7d75a5f9180bca7860ee23...

Powered by Google App Engine
This is Rietveld 408576698