Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2656893002: Revert of Fix for google:instantExtendedEnabledKey replacement (Closed)

Created:
3 years, 11 months ago by Peter Kasting
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix for google:instantExtendedEnabledKey replacement (patchset #2 id:20001 of https://codereview.chromium.org/2524733008/ ) Reason for revert: Part 1 of 2: Reverting change that caused bug 680197 Original issue's description: > Fix for google:instantExtendedEnabledKey replacement > > This is fix for minor bug that was inserted in > google:instantExtendedEnabledKey replacement in > https://codereview.chromium.org/2516963002/. > Incorrect string literal was used in replacement. > > R=treib@chromium.org, pkasting@chromium.org > > Committed: https://crrev.com/e128f9d8f6ebe7064709a42805e3d3233f521e31 > Cr-Commit-Position: refs/heads/master@{#434456} TBR=treib@chromium.org,a-v-y@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2656893002 Cr-Commit-Position: refs/heads/master@{#446165} Committed: https://chromium.googlesource.com/chromium/src/+/0d3069a5ad51f4d337927f5a1ed4e0945488d7c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -28 lines) Patch
M components/search_engines/template_url.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M components/search_engines/template_url_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Peter Kasting
Created Revert of Fix for google:instantExtendedEnabledKey replacement
3 years, 11 months ago (2017-01-25 22:02:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656893002/1
3 years, 11 months ago (2017-01-25 22:03:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0d3069a5ad51f4d337927f5a1ed4e0945488d7c1
3 years, 11 months ago (2017-01-25 23:46:06 UTC) #6
Alexander Yashkin
3 years, 11 months ago (2017-01-26 05:24:10 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698