New MenuController Checks

New MenuController Checks

Add additional checks to MenuController and MenuRunnerImpl to help find the root
cause of a use-after-free.

BUG=683087
Review-Url: https://codereview.chromium.org/2656823008
Cr-Commit-Position: refs/heads/master@{#446796}
Committed: https://chromium.googlesource.com/chromium/src/+/07c6e27a5cea714d7fdfbb297b998a531eb45371

[jonross, 2017-01-27 19:47:06]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-01-27 19:47:06]

Hi Sky@,

Here are some proposed CHECKS for menu code to try to get earlier stack traces
from the fuzzing. Hopefully to track down the root cause.

[sky, 2017-01-27 20:16:47]

https://codereview.chromium.org/2656823008/diff/1/ui/views/controls/menu/menu...
File ui/views/controls/menu/menu_controller.h (right):

https://codereview.chromium.org/2656823008/diff/1/ui/views/controls/menu/menu...
ui/views/controls/menu/menu_controller.h:577: // If true running has began and
there are still delegates which have not been
Please add references to bug where with a TODO that this is temporary to track
down bug. Same thing for changes in MenuRunnerImpl.

[jonross, 2017-01-27 20:27:36]

https://codereview.chromium.org/2656823008/diff/1/ui/views/controls/menu/menu...
File ui/views/controls/menu/menu_controller.h (right):

https://codereview.chromium.org/2656823008/diff/1/ui/views/controls/menu/menu...
ui/views/controls/menu/menu_controller.h:577: // If true running has began and
there are still delegates which have not been
On 2017/01/27 20:16:47, sky wrote:
> Please add references to bug where with a TODO that this is temporary to track
> down bug. Same thing for changes in MenuRunnerImpl.

Done.

[sky, 2017-01-27 20:35:48]

LGTM

[jonross, 2017-01-27 21:03:32]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-01-27 21:04:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 22:31:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485551012776180,
"parent_rev": "b8bb2c12fe549009f02235f31355307f21a52eec", "commit_rev":
"07c6e27a5cea714d7fdfbb297b998a531eb45371"}

[commit-bot: I haz the power, 2017-01-27 22:31:35]

Description was changed from

==========
New MenuController Checks

Add additional checks to MenuController and MenuRunnerImpl to help find the root
cause of a use-after-free.

BUG=683087
==========

to

==========
New MenuController Checks

Add additional checks to MenuController and MenuRunnerImpl to help find the root
cause of a use-after-free.

BUG=683087

Review-Url: https://codereview.chromium.org/2656823008
Cr-Commit-Position: refs/heads/master@{#446796}
Committed:
https://chromium.googlesource.com/chromium/src/+/07c6e27a5cea714d7fdfbb297b99...
==========

[commit-bot: I haz the power, 2017-01-27 22:31:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/07c6e27a5cea714d7fdfbb297b99...