run-webkit-tests: Extract slowness information from MANIFEST.json.

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
index 80a92d76767a3454cb98a7b5b2b834f9fcc07687..5f0a805828d0f2456311f1360bc46ee4f4809def 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -762,6 +762,16 @@ class Port(object):
             return items['testharness'][path_in_wpt]
         return None
 
+    def is_slow_wpt_test(self, test_file):
+        match = re.search(r'external/wpt/(.*)$', test_file)

[qyearsley, 2017/01/25 19:16:45]

If test_file is always relative to LayoutTests, then maybe we want re.match
instead of re.search?

  re.search('external/wpt/(.*)$', 'some/subdir/external/wpt/...')  ->  Match
  re.match('external/wpt/(.*)$', 'some/subdir/external/wpt/...')  ->  None

Also, since * is greedy by default, $ is optional:

  re.match('imported/wpt/(.*)', 'imported/wpt/foo/bar.html').group(1)  -> 
'foo/bar.html'

[tkent, 2017/01/25 23:25:12]

Done.

+        if not match:
+            return False
+        items = self._manifest_items_for_path(match.group(1))
+        if items is None or len(items) == 0:

[qyearsley, 2017/01/25 19:16:45]

This could also (optionally) be:
  if not items: ...

[tkent, 2017/01/25 23:25:12]

Done.

+            return False
+        options = items[0][1]

[qyearsley, 2017/01/25 19:16:45]

Depending on the type of test, this will be either items[0][1] or items[0][2],
because in the new manifest format, for reftests the options are third, e.g.:

  ...
  "reftest": {
   "html/dom/elements/global-attributes/dir_auto-EN-L.html": [
    [
     "/html/dom/elements/global-attributes/dir_auto-EN-L.html",
     [
      [
       "/html/dom/elements/global-attributes/dir_auto-EN-L-ref.html",
       "=="
      ]
     ],
     {"timeout": "long"}
    ]
   ],
   ...
  }
  ...

Maybe it might make sense to add little helper functions to get the "url" and
"options" partfrom a manifest item?

[tkent, 2017/01/25 23:25:12]

Done.
BTW, I found the field was called "extras" in manifest tool.

+        return 'timeout' in options and options['timeout'] == 'long'
+
     ALL_TEST_TYPES = ['audio', 'harness', 'pixel', 'ref', 'text', 'unknown']
 
     def test_type(self, test_name):