Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2656743005:
Implement should().message() for in-task message display (Closed)
|
Created:
3 years, 10 months ago by hongchan Modified:
3 years, 10 months ago Reviewers:
Raymond Toy CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionImplement should().message() for in-task message display
The legacy Audit() had Should().summarize(), so it is sensible to have
the replacement of it in the new Audit - until the transition to the
new Audit actually is finished.
Once the transition is completed, the task runner should be able to
serve the summary and this message() method will not be needed.
BUG=685821
TEST=
LayoutTests/webaudio/unit-tests/audit.html
LayoutTests/webaudio/unit-tests/audit-failures.html
Review-Url: https://codereview.chromium.org/2656743005
Cr-Commit-Position: refs/heads/master@{#446801}
Committed: https://chromium.googlesource.com/chromium/src/+/700d980db862c9780cd20f64a9527ad07687f51b
Patch Set 1 : Initial Commit #
Messages
Total messages: 35 (27 generated)
hongchan@chromium.org changed reviewers: + rtoy@chromium.org
PTAL. Hopefully this change is good enough for what you asked.
Should be good enough. lgtm.
The CQ bit was checked by hongchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Implement should().message() for in-task message display The legacy Audit() had Should().summarize(), so it is sensible to have the replacement of it in the new Audit - until the transition to the new Audit actually is finished. Once the transition is completed, the task runner should be able to serve the summarize and we should not need this message() method. BUG=685821 TEST= LayoutTests/webaudio/unit-tests/audit.html LayoutTests/webaudio/unit-tests/audit-failures.html ========== to ========== Implement should().message() for in-task message display The legacy Audit() had Should().summarize(), so it is sensible to have the replacement of it in the new Audit - until the transition to the new Audit actually is finished. Once the transition is completed, the task runner should be able to serve the summary and this message() method will not be needed. BUG=685821 TEST= LayoutTests/webaudio/unit-tests/audit.html LayoutTests/webaudio/unit-tests/audit-failures.html ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by hongchan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rtoy@chromium.org Link to the patchset: https://codereview.chromium.org/2656743005/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by hongchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by hongchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by hongchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by hongchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hongchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485555077699760,
"parent_rev": "83d8f196d15bc31bfbce50ecc435016ba2a96bcf", "commit_rev":
"700d980db862c9780cd20f64a9527ad07687f51b"}
Message was sent while issue was closed.
Description was changed from ========== Implement should().message() for in-task message display The legacy Audit() had Should().summarize(), so it is sensible to have the replacement of it in the new Audit - until the transition to the new Audit actually is finished. Once the transition is completed, the task runner should be able to serve the summary and this message() method will not be needed. BUG=685821 TEST= LayoutTests/webaudio/unit-tests/audit.html LayoutTests/webaudio/unit-tests/audit-failures.html ========== to ========== Implement should().message() for in-task message display The legacy Audit() had Should().summarize(), so it is sensible to have the replacement of it in the new Audit - until the transition to the new Audit actually is finished. Once the transition is completed, the task runner should be able to serve the summary and this message() method will not be needed. BUG=685821 TEST= LayoutTests/webaudio/unit-tests/audit.html LayoutTests/webaudio/unit-tests/audit-failures.html Review-Url: https://codereview.chromium.org/2656743005 Cr-Commit-Position: refs/heads/master@{#446801} Committed: https://chromium.googlesource.com/chromium/src/+/700d980db862c9780cd20f64a952... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/700d980db862c9780cd20f64a952... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
