Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2656723003: [SubZero] Fix code generation of AtomicCmpxchg (Closed)

Created:
3 years, 11 months ago by jaydeep.patil
Modified:
3 years, 11 months ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[SubZero] Fix code generation of AtomicCmpxchg The patch fixes a code generation issue occurred in the 2nd iteration of LL-SC loop. R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=fc8f6bfae75430b00d8d6fbf78e62da4c3abed9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M src/IceTargetLoweringMIPS32.cpp View 6 chunks +21 lines, -10 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll View 4 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jaydeep.patil
3 years, 11 months ago (2017-01-25 06:58:42 UTC) #3
Jim Stichnoth
lgtm
3 years, 11 months ago (2017-01-25 16:01:38 UTC) #4
Jim Stichnoth
3 years, 11 months ago (2017-01-26 06:53:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc8f6bfae75430b00d8d6fbf78e62da4c3abed9d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698