Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2656713002: Merge to M57: Remove popup overlay from MHTML when requested (Closed)

Created:
3 years, 11 months ago by jianli
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Merge to M57: Remove popup overlay from MHTML when requested If the page is being loaded in background mode and saved to MHTML, we should try to remove popup overlay that obstructs viewing the normal content. This is controlled by MHTMLGenerationParams:: remove_popup_overlay. BUG=684091 TEST=new tests added Review-Url: https://codereview.chromium.org/2640923003 Cr-Commit-Position: refs/heads/master@{#445612} (cherry picked from commit ec72fc4b04c800b1d54063d09b79350fdcd0cc15) Review-Url: https://codereview.chromium.org/2656713002 . Cr-Commit-Position: refs/branch-heads/2987@{#75} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/dd7ad8044610e0c92d8cc3695c19bf78ec3013ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -41 lines) Patch
M chrome/browser/android/offline_pages/background_loader_offliner.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_bridge.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc View 9 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/prerendering_offliner.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/recent_tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/core/offline_page_archiver.h View 2 chunks +11 lines, -3 lines 0 comments Download
M components/offline_pages/core/offline_page_client_policy.h View 4 chunks +4 lines, -4 lines 0 comments Download
M components/offline_pages/core/offline_page_model.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/offline_pages/core/offline_page_model.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/offline_pages/core/offline_page_model_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download
M components/offline_pages/core/offline_page_model_impl_unittest.cc View 5 chunks +36 lines, -4 lines 0 comments Download
M components/offline_pages/core/offline_page_test_archiver.h View 3 chunks +6 lines, -1 line 0 comments Download
M components/offline_pages/core/offline_page_test_archiver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M content/browser/download/mhtml_generation_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/mhtml_generation_params.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/popup.html View 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializer.cpp View 5 chunks +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp View 4 chunks +30 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/frameserialization/popup.html View 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameSerializer.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jianli
3 years, 11 months ago (2017-01-24 22:08:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd7ad8044610e0c92d8cc3695c19bf78ec3013ce.

Powered by Google App Engine
This is Rietveld 408576698