Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2656683003: Revert of DevTools: Console: Provide autocompletions for Maps (Closed)

Created:
3 years, 11 months ago by chenwilliam
Modified:
3 years, 11 months ago
Reviewers:
kozy, einbinder, dgozman, luoe
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Console: Provide autocompletions for Maps (patchset #6 id:100001 of https://codereview.chromium.org/2639703002/ ) Reason for revert: Causing closure compilation failure on main waterfall Original issue's description: > DevTools: Console: Provide autocompletions for Maps > > BUG=659152 > > Review-Url: https://codereview.chromium.org/2639703002 > Cr-Commit-Position: refs/heads/master@{#445811} > Committed: https://chromium.googlesource.com/chromium/src/+/a2ab5d688b1b01c2fa805a57762aa9d1e2c4499c TBR=dgozman@chromium.org,luoe@chromium.org,einbinder@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659152 Review-Url: https://codereview.chromium.org/2656683003 Cr-Commit-Position: refs/heads/master@{#445846} Committed: https://chromium.googlesource.com/chromium/src/+/22b7b42602956cc363a44cddf41c8bbeff1757d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -157 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html View 3 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions-expected.txt View 1 chunk +4 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js View 9 chunks +14 lines, -122 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
chenwilliam
Created Revert of DevTools: Console: Provide autocompletions for Maps
3 years, 11 months ago (2017-01-24 22:42:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656683003/1
3 years, 11 months ago (2017-01-24 22:43:14 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-24 22:43:16 UTC) #5
kozy
lgtm
3 years, 11 months ago (2017-01-24 22:43:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656683003/1
3 years, 11 months ago (2017-01-24 22:45:00 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 22:46:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/22b7b42602956cc363a44cddf41c...

Powered by Google App Engine
This is Rietveld 408576698