Add rec-2020 and p3 color spaces to canvas

Add rec-2020 and p3 color spaces to canvas

This change adds two new color spaces to canvas: linear-rec-2020 and
linear-p3. It also adds two layout tests that examines if the Skia
rendering pipeline correctly renders the canvases with these color
space tags.

We still do not have end-to-end layout tests for these color spaces
(and also linear-rgb). This issue will be addressed later.

This change also inherits this issue from the previous CL:
"getImage data had to work around some output format limitations in skia."

BUG=634542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2656623002
Cr-Commit-Position: refs/heads/master@{#446751}
Committed: https://chromium.googlesource.com/chromium/src/+/95e575c95dbae022874c992ac7c87cde406d38a3

[zakerinasab1, 2017-01-24 16:25:53]

Description was changed from

==========
Add linear-rec-2020 and linear-p3 color spaces to canvas

This change adds two new color spaces to canvas: linear-rec-2020 and
linear-p3. It also adds two layout tests that examines if the Skia
rendering pipeline correctly renders the canvases with these color
space tags.

We still do not have end-to-end layout tests for these color spaces
(and also linear-rgb). This issue will be addressed later.

This change also inherits this issue from the previous CL:
"getImage data had to work around some output format limitations in skia."

BUG=634542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add linear-rec-2020 and linear-p3 color spaces to canvas

This change adds two new color spaces to canvas: linear-rec-2020 and
linear-p3. It also adds two layout tests that examines if the Skia
rendering pipeline correctly renders the canvases with these color
space tags.

We still do not have end-to-end layout tests for these color spaces
(and also linear-rgb). This issue will be addressed later.

This change also inherits this issue from the previous CL:
"getImage data had to work around some output format limitations in skia."

BUG=634542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[zakerinasab1, 2017-01-24 16:25:54]

zakerinasab@google.com changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2017-01-26 19:12:42]

https://codereview.chromium.org/2656623002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl
(right):

https://codereview.chromium.org/2656623002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl:25:
enum CanvasColorSpace { "legacy-srgb", "srgb", "linear-rgb", "linear-rec-2020",
"linear-p3"};
We should match the strings used by the color-gamut media query: "p3", "rec2020"

https://codereview.chromium.org/2656623002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
(right):

https://codereview.chromium.org/2656623002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h:55:
kLinearRec2020CanvasColorSpace,
We should remove the "Linear" here.  We are going to decouple the notions of
numeric format and color space in the future, and the use of the transfer curve
is most likely going to be tied to the numeric format. Eg. float16 is linear,
8-8-8-8 and 10-10-10-2 use gamma correction.

[zakerinasab1, 2017-01-26 20:42:33]

zakerinasab@google.com changed reviewers:
+ zakerinasab@google.com

[zakerinasab1, 2017-01-26 20:42:34]

Comments addressed. PTAL.

https://codereview.chromium.org/2656623002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl
(right):

https://codereview.chromium.org/2656623002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl:25:
enum CanvasColorSpace { "legacy-srgb", "srgb", "linear-rgb", "linear-rec-2020",
"linear-p3"};
On 2017/01/26 19:12:42, Justin Novosad wrote:
> We should match the strings used by the color-gamut media query: "p3",
"rec2020"

Done.

https://codereview.chromium.org/2656623002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
(right):

https://codereview.chromium.org/2656623002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h:55:
kLinearRec2020CanvasColorSpace,
On 2017/01/26 19:12:42, Justin Novosad wrote:
> We should remove the "Linear" here.  We are going to decouple the notions of
> numeric format and color space in the future, and the use of the transfer
curve
> is most likely going to be tied to the numeric format. Eg. float16 is linear,
> 8-8-8-8 and 10-10-10-2 use gamma correction.

Done.

[Justin Novosad, 2017-01-26 20:50:38]

lgtm

[zakerinasab1, 2017-01-26 21:01:52]

Description was changed from

==========
Add linear-rec-2020 and linear-p3 color spaces to canvas

This change adds two new color spaces to canvas: linear-rec-2020 and
linear-p3. It also adds two layout tests that examines if the Skia
rendering pipeline correctly renders the canvases with these color
space tags.

We still do not have end-to-end layout tests for these color spaces
(and also linear-rgb). This issue will be addressed later.

This change also inherits this issue from the previous CL:
"getImage data had to work around some output format limitations in skia."

BUG=634542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add rec-2020 and p3 color spaces to canvas

This change adds two new color spaces to canvas: linear-rec-2020 and
linear-p3. It also adds two layout tests that examines if the Skia
rendering pipeline correctly renders the canvases with these color
space tags.

We still do not have end-to-end layout tests for these color spaces
(and also linear-rgb). This issue will be addressed later.

This change also inherits this issue from the previous CL:
"getImage data had to work around some output format limitations in skia."

BUG=634542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[zakerinasab1, 2017-01-26 21:02:03]

The CQ bit was checked by zakerinasab@google.com

[commit-bot: I haz the power, 2017-01-26 21:02:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 23:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:14:49]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[zakerinasab, 2017-01-27 17:53:10]

The CQ bit was checked by zakerinasab@chromium.org

[zakerinasab, 2017-01-27 17:53:11]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2656623002/#ps80001
(title: "Fixing broken layout tests")

[commit-bot: I haz the power, 2017-01-27 17:53:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 18:01:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:01:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[zakerinasab1, 2017-01-27 18:38:58]

The CQ bit was checked by zakerinasab@google.com

[zakerinasab1, 2017-01-27 18:38:58]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2656623002/#ps100001
(title: "Rebaseline")

[commit-bot: I haz the power, 2017-01-27 18:39:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 20:31:06]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485542338177900,
"parent_rev": "2fc8a7790843c9a31a1f251d25395277b9077a82", "commit_rev":
"95e575c95dbae022874c992ac7c87cde406d38a3"}

[commit-bot: I haz the power, 2017-01-27 20:31:35]

Description was changed from

==========
Add rec-2020 and p3 color spaces to canvas

This change adds two new color spaces to canvas: linear-rec-2020 and
linear-p3. It also adds two layout tests that examines if the Skia
rendering pipeline correctly renders the canvases with these color
space tags.

We still do not have end-to-end layout tests for these color spaces
(and also linear-rgb). This issue will be addressed later.

This change also inherits this issue from the previous CL:
"getImage data had to work around some output format limitations in skia."

BUG=634542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add rec-2020 and p3 color spaces to canvas

This change adds two new color spaces to canvas: linear-rec-2020 and
linear-p3. It also adds two layout tests that examines if the Skia
rendering pipeline correctly renders the canvases with these color
space tags.

We still do not have end-to-end layout tests for these color spaces
(and also linear-rgb). This issue will be addressed later.

This change also inherits this issue from the previous CL:
"getImage data had to work around some output format limitations in skia."

BUG=634542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2656623002
Cr-Commit-Position: refs/heads/master@{#446751}
Committed:
https://chromium.googlesource.com/chromium/src/+/95e575c95dbae022874c992ac7c8...
==========

[commit-bot: I haz the power, 2017-01-27 20:31:36]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/95e575c95dbae022874c992ac7c8...