Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2656613002: Removing unused SpeechRecognitionManager::GetAudioInputDeviceModel() (Closed)

Created:
3 years, 11 months ago by o1ka
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, audio-mojo-cl_google.com, Avi (use Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing unused SpeechRecognitionManager::GetAudioInputDeviceModel() BUG=672468 Review-Url: https://codereview.chromium.org/2656613002 Cr-Commit-Position: refs/heads/master@{#446001} Committed: https://chromium.googlesource.com/chromium/src/+/8c0bd26598ee23f3f5d85d095fa9eb33ba04108b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M content/browser/speech/speech_recognition_manager_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognition_manager_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/browser/speech_recognition_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/test/fake_speech_recognition_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/fake_speech_recognition_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
o1ka
Tommi could you PTAL?
3 years, 11 months ago (2017-01-24 17:20:57 UTC) #7
tommi (sloooow) - chröme
lgtm. looks like the trybot errors are unrelated (right?)
3 years, 11 months ago (2017-01-24 17:22:39 UTC) #8
o1ka
On 2017/01/24 17:22:39, tommi (krómíum) wrote: > lgtm. looks like the trybot errors are unrelated ...
3 years, 11 months ago (2017-01-24 17:23:36 UTC) #9
o1ka
avi@chromium.org: Could you RS content/public/browser/speech_recognition_manager.h?
3 years, 11 months ago (2017-01-24 17:24:20 UTC) #11
o1ka
Changing owner since avi@ is away. kinuko@chromium.org: Could you RS content/public/browser/speech_recognition_manager.h?
3 years, 11 months ago (2017-01-25 08:59:53 UTC) #14
kinuko
lgtm
3 years, 11 months ago (2017-01-25 12:04:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656613002/1
3 years, 11 months ago (2017-01-25 12:05:51 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 12:11:02 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c0bd26598ee23f3f5d85d095fa9...

Powered by Google App Engine
This is Rietveld 408576698