Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2656573002: Sign-in dialogs: Use the same font-weight when buttons are focused. (Closed)

Created:
3 years, 11 months ago by msarda
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sign-in dialogs: Use the same font-weight when buttons are focused. This CL changes the font-weight of the primary and secondary buttons of the sign-in dialogs to 500. This matches the font-weight of the buttons when they are unfocused and thus avoid the weird rendering issues when the buttons are focused. BUG=681758 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2656573002 Cr-Commit-Position: refs/heads/master@{#445999} Committed: https://chromium.googlesource.com/chromium/src/+/dacb8febda9ad9ac9c7724e4fe1aa3cc0bef3cfd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/signin/signin_shared_css.html View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
msarda
Please take a look.
3 years, 11 months ago (2017-01-24 09:26:15 UTC) #3
Dan Beam
lgtm assuming bettes@ wants this
3 years, 11 months ago (2017-01-24 16:39:35 UTC) #5
msarda
Note that with my change there is no difference in the appearance of the buttons, ...
3 years, 11 months ago (2017-01-25 09:55:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656573002/1
3 years, 11 months ago (2017-01-25 09:56:03 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 12:08:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dacb8febda9ad9ac9c7724e4fe1a...

Powered by Google App Engine
This is Rietveld 408576698