Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2656533002: Fix json5 style for Settings, CSSValueKeywords, and SVGCSSValueKeywords. (Closed)

Created:
3 years, 11 months ago by ktyliu
Modified:
3 years, 11 months ago
Reviewers:
meade_UTC10, sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix json5 style for Settings, CSSValueKeywords, and SVGCSSValueKeywords. BUG=677884 Review-Url: https://codereview.chromium.org/2656533002 Cr-Commit-Position: refs/heads/master@{#445970} Committed: https://chromium.googlesource.com/chromium/src/+/492b051065545ec01b91f9ea0034e8563201a937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2202 lines, -2202 lines) Patch
M third_party/WebKit/Source/core/css/CSSValueKeywords.json5 View 1 chunk +1119 lines, -1119 lines 0 comments Download
M third_party/WebKit/Source/core/css/SVGCSSValueKeywords.json5 View 1 chunk +259 lines, -259 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.json5 View 1 chunk +824 lines, -824 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
ktyliu
Hi Eddy, Can I send this CL to you to review first since we're encouraged ...
3 years, 11 months ago (2017-01-24 03:07:03 UTC) #4
meade_UTC10
lgtm
3 years, 11 months ago (2017-01-25 04:22:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656533002/1
3 years, 11 months ago (2017-01-25 04:24:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/349619)
3 years, 11 months ago (2017-01-25 04:32:54 UTC) #11
ktyliu
Thanks Eddy for review. Adding Sasha until Eddy gets OWNERS.
3 years, 11 months ago (2017-01-25 04:41:47 UTC) #13
sashab
RS lgtm but please fix up your CL desc ;) lol
3 years, 11 months ago (2017-01-25 04:52:53 UTC) #14
ktyliu
On 2017/01/25 at 04:52:53, sashab wrote: > RS lgtm but please fix up your CL ...
3 years, 11 months ago (2017-01-25 05:01:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656533002/1
3 years, 11 months ago (2017-01-25 05:01:35 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 06:31:26 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/492b051065545ec01b91f9ea0034...

Powered by Google App Engine
This is Rietveld 408576698