Rename media_resources -> localized_strings

Rename media_resources -> localized_strings

We can do this to avoid confusion about these files having any relation
to MediaResource, which is going to be the new name for the
DemuxerStreamProvider.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2656523002
Cr-Commit-Position: refs/heads/master@{#446125}
Committed: https://chromium.googlesource.com/chromium/src/+/5d4234dbcf17b8ea17ce16e0a00db780ca23873b

[servolk, 2017-01-24 02:05:21]

Description was changed from

==========
Rename media_resources -> media_localization_resources

We can do this to avoid confusion about these files having any relation
to MediaResource, which is going to be the new name for the
DemuxerStreamProvider.
==========

to

==========
Rename media_resources -> media_localization_resources

We can do this to avoid confusion about these files having any relation
to MediaResource, which is going to be the new name for the
DemuxerStreamProvider.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[servolk, 2017-01-24 02:05:26]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 02:06:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[servolk, 2017-01-24 02:06:26]

Description was changed from

==========
Rename media_resources -> media_localization_resources

We can do this to avoid confusion about these files having any relation
to MediaResource, which is going to be the new name for the
DemuxerStreamProvider.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rename media_resources -> media_localization_resources

We can do this to avoid confusion about these files having any relation
to MediaResource, which is going to be the new name for the
DemuxerStreamProvider.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[servolk, 2017-01-24 02:06:26]

servolk@chromium.org changed reviewers:
+ tguilbert@chromium.org, xhwang@chromium.org

[tguilbert, 2017-01-24 02:17:10]

LGTM % one comment.

https://codereview.chromium.org/2656523002/diff/1/media/base/fake_media_local...
File media/base/fake_media_localization_resources.h (right):

https://codereview.chromium.org/2656523002/diff/1/media/base/fake_media_local...
media/base/fake_media_localization_resources.h:11: void
SetUpFakeMediaResources();
NIT: Is SetUpFakeMediaLocalizationResources() overkill?

[commit-bot: I haz the power, 2017-01-24 05:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 05:09:39]

Dry run: This issue passed the CQ dry run.

[xhwang, 2017-01-24 05:51:47]

Thanks for the CL!

This is the first time I saw these files ;)

It seems like this file is all about LocalizedString, how about just
media/base/localized_string.* and media::LocalizedString?

[servolk, 2017-01-24 19:08:53]

On 2017/01/24 05:51:47, xhwang_slow wrote:
> Thanks for the CL!
> 
> This is the first time I saw these files ;)
> 
> It seems like this file is all about LocalizedString, how about just
> media/base/localized_string.* and media::LocalizedString?

Ok, sounds good to me, only it should probably be plural, i.e.
localized_strings.* and media::LocalizedStrings, right? I'll make this change
shortly.

[servolk, 2017-01-24 19:19:11]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[servolk, 2017-01-24 19:19:42]

Description was changed from

==========
Rename media_resources -> media_localization_resources

We can do this to avoid confusion about these files having any relation
to MediaResource, which is going to be the new name for the
DemuxerStreamProvider.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rename media_resources -> localized_strings

We can do this to avoid confusion about these files having any relation
to MediaResource, which is going to be the new name for the
DemuxerStreamProvider.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2017-01-24 19:19:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[servolk, 2017-01-24 19:19:52]

On 2017/01/24 19:08:53, servolk wrote:
> On 2017/01/24 05:51:47, xhwang_slow wrote:
> > Thanks for the CL!
> > 
> > This is the first time I saw these files ;)
> > 
> > It seems like this file is all about LocalizedString, how about just
> > media/base/localized_string.* and media::LocalizedString?
> 
> Ok, sounds good to me, only it should probably be plural, i.e.
> localized_strings.* and media::LocalizedStrings, right? I'll make this change
> shortly.

Done

[xhwang, 2017-01-24 19:27:09]

Thanks!!! LGTM

[servolk, 2017-01-24 19:29:37]

servolk@chromium.org changed reviewers:
+ thakis@chromium.org

[servolk, 2017-01-24 19:30:15]

On 2017/01/24 19:27:09, xhwang_slow wrote:
> Thanks!!! LGTM

Thanks
+thakis@ for chrome/ changes.

[commit-bot: I haz the power, 2017-01-24 21:21:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 21:21:10]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-01-25 14:53:01]

chrome lgtm

[Nico, 2017-01-25 14:53:05]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-01-25 14:53:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
tguilbert@chromium.org
Link to the patchset: https://codereview.chromium.org/2656523002/#ps20001
(title: "Rename into localized_strings.*")

[commit-bot: I haz the power, 2017-01-25 14:53:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 14:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 14:58:07]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[servolk, 2017-01-25 16:33:13]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2017-01-25 16:33:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 16:39:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 16:39:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[servolk, 2017-01-25 17:39:03]

The CQ bit was checked by servolk@chromium.org

[servolk, 2017-01-25 17:39:03]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
thakis@chromium.org, tguilbert@chromium.org
Link to the patchset: https://codereview.chromium.org/2656523002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-25 17:39:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 21:34:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485365943078020,
"parent_rev": "04a0e487ece54c7e1568f53e3dc8b247dcf6ca74", "commit_rev":
"5d4234dbcf17b8ea17ce16e0a00db780ca23873b"}

[commit-bot: I haz the power, 2017-01-25 21:35:01]

Description was changed from

==========
Rename media_resources -> localized_strings

We can do this to avoid confusion about these files having any relation
to MediaResource, which is going to be the new name for the
DemuxerStreamProvider.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rename media_resources -> localized_strings

We can do this to avoid confusion about these files having any relation
to MediaResource, which is going to be the new name for the
DemuxerStreamProvider.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2656523002
Cr-Commit-Position: refs/heads/master@{#446125}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d4234dbcf17b8ea17ce16e0a00d...
==========

[commit-bot: I haz the power, 2017-01-25 21:35:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5d4234dbcf17b8ea17ce16e0a00d...