Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2656443005:
Block 'ftp:' subresource requests from non-'ftp:' pages. (Closed)
|
Created:
3 years, 11 months ago by Mike West Modified:
3 years, 10 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, Paweł Hajdan Jr., tyoshino+watch_chromium.org, Yoav Weiss Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBlock 'ftp:' subresource requests from non-'ftp:' pages.
Usage of the 'ftp:' protocol when requesting subresources from non-'ftp:'
clients has slowly declined over the last few years to the point where
it represents a [negligable amount of traffic][1]. The protocol does not
support modern requirements, like encryption, and we're interested in
removing support from //net.
To that end, this patch alters Fetch to block FTP subresources from
webby clients. That is, a page delivered from `http://example.com/`
will receive a network error response to requests like those generated
from `<img src='ftp://example.com/image.png'>`.
Intent: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/bIJdwwoQ98U/-F1aL2FgBAAJ
PR against Fetch: https://github.com/whatwg/fetch/pull/464.
BUG=435547
Review-Url: https://codereview.chromium.org/2656443005
Cr-Commit-Position: refs/heads/master@{#451709}
Committed: https://chromium.googlesource.com/chromium/src/+/e4cfac9d67e1b30d60f84def4a7c7cb5f4883c66
Patch Set 1 #Patch Set 2 : Rebase. #Patch Set 3 : Tests #Patch Set 4 : experimental #Patch Set 5 : Compile first, then upload... #Patch Set 6 : test #
Messages
Total messages: 41 (35 generated)
The CQ bit was checked by mkwst@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mkwst@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mkwst@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mkwst@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
experimental
The CQ bit was checked by mkwst@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mkwst@chromium.org changed reviewers: + jochen@chromium.org
Jochen, I'd like to block this in tests for M58, and plan to remove the runtime check in M59 (which is what the deprecation message promises). WDYT?
The CQ bit was checked by mkwst@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #5 (id:80001) has been deleted
The CQ bit was checked by mkwst@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mkwst@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hrm. Looks like the experimental flag doesn't persist through to unit/browser tests... which I guess makes sense? But maybe we should change that?
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mkwst@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487658360330310,
"parent_rev": "c49d32e2554c23beb02be20061c0b9784476fe98", "commit_rev":
"e4cfac9d67e1b30d60f84def4a7c7cb5f4883c66"}
Message was sent while issue was closed.
Description was changed from ========== Block 'ftp:' subresource requests from non-'ftp:' pages. Usage of the 'ftp:' protocol when requesting subresources from non-'ftp:' clients has slowly declined over the last few years to the point where it represents a [negligable amount of traffic][1]. The protocol does not support modern requirements, like encryption, and we're interested in removing support from //net. To that end, this patch alters Fetch to block FTP subresources from webby clients. That is, a page delivered from `http://example.com/` will receive a network error response to requests like those generated from `<img src='ftp://example.com/image.png'>`. Intent: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/bIJdwwoQ98U/-F... PR against Fetch: https://github.com/whatwg/fetch/pull/464. BUG=435547 ========== to ========== Block 'ftp:' subresource requests from non-'ftp:' pages. Usage of the 'ftp:' protocol when requesting subresources from non-'ftp:' clients has slowly declined over the last few years to the point where it represents a [negligable amount of traffic][1]. The protocol does not support modern requirements, like encryption, and we're interested in removing support from //net. To that end, this patch alters Fetch to block FTP subresources from webby clients. That is, a page delivered from `http://example.com/` will receive a network error response to requests like those generated from `<img src='ftp://example.com/image.png'>`. Intent: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/bIJdwwoQ98U/-F... PR against Fetch: https://github.com/whatwg/fetch/pull/464. BUG=435547 Review-Url: https://codereview.chromium.org/2656443005 Cr-Commit-Position: refs/heads/master@{#451709} Committed: https://chromium.googlesource.com/chromium/src/+/e4cfac9d67e1b30d60f84def4a7c... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as https://chromium.googlesource.com/chromium/src/+/e4cfac9d67e1b30d60f84def4a7c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
