MD History: Add routing for grouped history mode.

MD History: Add routing for grouped history mode.

This adds routes of the form `chrome://history/history/week?offset=1`
to grouped MD History. When grouped history is not enabled, these routes
are ignored.

This CL also enables (grouped) MD History when the
--enable-grouped-history flag is present.

BUG=675841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2656443004
Cr-Commit-Position: refs/heads/master@{#446955}
Committed: https://chromium.googlesource.com/chromium/src/+/2112ddfabe748e6a6a6f9fdbb7de7ade58326957

[tsergeant, 2017-01-24 03:32:10]

Description was changed from

==========
MD History: Add routing for grouped history mode.

This adds routes of the form `chrome://history/history/week?offset=1`
to grouped MD History. When grouped history is not enabled, these routes
are ignored.

This CL also enables (grouped) MD History when the
--enable-grouped-history flag is present.

BUG=675841
==========

to

==========
MD History: Add routing for grouped history mode.

This adds routes of the form `chrome://history/history/week?offset=1`
to grouped MD History. When grouped history is not enabled, these routes
are ignored.

This CL also enables (grouped) MD History when the
--enable-grouped-history flag is present.

BUG=675841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-01-24 05:40:45]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 05:40:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-01-24 06:32:00]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 06:32:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-01-24 06:32:31]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-01-24 06:32:32]

Enjoy

[commit-bot: I haz the power, 2017-01-24 07:32:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 07:33:00]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-01-27 03:47:34]

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:227: <paper-tab
value="2">$i18n{rangeMonth}</paper-tab>
Tangent: these look terrible before the lazy load bundle comes in. We should
probably shim these.

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.js (right):

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.js:147: return;
When can this happen?

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:60: list.initialData =
results;
Explain the lazy load problem here.

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/router.js (right):

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/router.js:19: queryResult: Object,
Remove.

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/router.js:28: /** @private{boolean} */
nit: Missing a space.

[tsergeant, 2017-01-30 02:07:51]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 02:07:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-01-30 02:13:14]

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:227: <paper-tab
value="2">$i18n{rangeMonth}</paper-tab>
On 2017/01/27 03:47:34, calamity wrote:
> Tangent: these look terrible before the lazy load bundle comes in. We should
> probably shim these.

Already on it: https://codereview.chromium.org/2651013004/

(hiding is easier than shimming)

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.js (right):

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.js:147: return;
On 2017/01/27 03:47:34, calamity wrote:
> When can this happen?

It gets called when queryResult.info is set to null during initialization:
https://cs.chromium.org/chromium/src/chrome/browser/resources/md_history/app....

This already happens, but it just becomes a problem now because it's possible
for the `if` conditionals to be true.

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:60: list.initialData =
results;
On 2017/01/27 03:47:34, calamity wrote:
> Explain the lazy load problem here.

Done.

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/router.js (right):

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/router.js:19: queryResult: Object,
On 2017/01/27 03:47:34, calamity wrote:
> Remove.

Oops, done.

https://codereview.chromium.org/2656443004/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/router.js:28: /** @private{boolean} */
On 2017/01/27 03:47:34, calamity wrote:
> nit: Missing a space.

Done.

[tsergeant, 2017-01-30 02:13:27]

Patchset #4 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-01-30 03:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 03:04:18]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-01-30 03:34:15]

lgtm!

What a circuitous route.

[tsergeant, 2017-01-30 03:38:24]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-01-30 03:38:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 03:42:12]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485747504209390,
"parent_rev": "86bf5f7085db57c142eebd84d7da7dc4b81c181a", "commit_rev":
"2112ddfabe748e6a6a6f9fdbb7de7ade58326957"}

[commit-bot: I haz the power, 2017-01-30 03:43:54]

Description was changed from

==========
MD History: Add routing for grouped history mode.

This adds routes of the form `chrome://history/history/week?offset=1`
to grouped MD History. When grouped history is not enabled, these routes
are ignored.

This CL also enables (grouped) MD History when the
--enable-grouped-history flag is present.

BUG=675841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Add routing for grouped history mode.

This adds routes of the form `chrome://history/history/week?offset=1`
to grouped MD History. When grouped history is not enabled, these routes
are ignored.

This CL also enables (grouped) MD History when the
--enable-grouped-history flag is present.

BUG=675841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2656443004
Cr-Commit-Position: refs/heads/master@{#446955}
Committed:
https://chromium.googlesource.com/chromium/src/+/2112ddfabe748e6a6a6f9fdbb7de...
==========

[commit-bot: I haz the power, 2017-01-30 03:43:55]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2112ddfabe748e6a6a6f9fdbb7de...