Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2656443003: Make the uses of Resource::m_resourceRequest/m_response const if applicable (Closed)

Created:
3 years, 11 months ago by hiroshige
Modified:
3 years, 11 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the uses of Resource::m_resourceRequest/m_response const if applicable This CL - Marks some Resource methods as const, and - Replace |m_resourceRequest| and |m_response| with with resourceRequest() and response(), respectively, to make it clear that these references are const. BUG=667641 Review-Url: https://codereview.chromium.org/2656443003 Cr-Commit-Position: refs/heads/master@{#445668} Committed: https://chromium.googlesource.com/chromium/src/+/999a78abf761b51b7d02ee13c1cc3a1bc75b6db7

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M third_party/WebKit/Source/core/fetch/Resource.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 13 chunks +28 lines, -28 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
hiroshige
PTAL.
3 years, 11 months ago (2017-01-24 05:07:23 UTC) #9
yhirano
lgtm
3 years, 11 months ago (2017-01-24 05:43:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656443003/20001
3 years, 11 months ago (2017-01-24 06:47:55 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 06:53:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/999a78abf761b51b7d02ee13c1cc...

Powered by Google App Engine
This is Rietveld 408576698