Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2656433005: Use explicit WebString conversions in extensions/ (Closed)

Created:
3 years, 11 months ago by kinuko
Modified:
3 years, 11 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit WebString conversions in extensions/ As we're deprecating implicit conversions for WebString <-> string16 replace them with explicit methods. (See crbug.com/667131 for more details) BUG=667131 Review-Url: https://codereview.chromium.org/2656433005 Cr-Commit-Position: refs/heads/master@{#445892} Committed: https://chromium.googlesource.com/chromium/src/+/24f2fe82c4cfa9fa01d697b348a5ca88a3a576f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M extensions/renderer/api/automation/automation_api_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/dom_activity_logger.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M extensions/renderer/extension_frame_helper.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
kinuko
Mechanical changes only- can you review?
3 years, 11 months ago (2017-01-24 14:22:38 UTC) #5
Devlin
lgtm
3 years, 11 months ago (2017-01-24 16:48:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656433005/1
3 years, 11 months ago (2017-01-25 01:03:16 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 01:14:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/24f2fe82c4cfa9fa01d697b348a5...

Powered by Google App Engine
This is Rietveld 408576698