Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2656433004: - Plumbs through native touch calibration from MD settings to display manager via the system dis… (Closed)

Created:
3 years, 11 months ago by jdufault
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

- Plumbs through native touch calibration from MD settings to display manager via the system display API. Modifications done to System Display API: - Renames API method. - Splits touchCalibrationSet() method into 2 separate methods. (Why? https://docs.google.com/document/d/1fFvSk35wWRoKspJRR1hYMqlfeyhYO4l7s92g-5m9vPo/) - Updates SystemDisplayAPI Test BUG=672990 COMPONENT=Display Info Provider, Chrome OS, System Display API, Touch Calibration CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2638903003 Cr-Commit-Position: refs/heads/master@{#444950} (cherry picked from commit 5f64df43034f52aea554ca764633c58a72f44831) Review-Url: https://codereview.chromium.org/2656433004 . Cr-Commit-Position: refs/branch-heads/2987@{#36} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/78cf3269633c9134933f70d6087faa42f440dd96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -141 lines) Patch
M chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.h View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc View 6 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.h View 3 chunks +18 lines, -4 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.cc View 7 chunks +93 lines, -13 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 9 chunks +52 lines, -35 lines 0 comments Download
M chrome/browser/resources/settings/device_page/display.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/system_display/display_info_provider.h View 3 chunks +12 lines, -5 lines 0 comments Download
M extensions/browser/api/system_display/display_info_provider.cc View 2 chunks +13 lines, -5 lines 0 comments Download
M extensions/browser/api/system_display/system_display_api.h View 1 chunk +26 lines, -12 lines 0 comments Download
M extensions/browser/api/system_display/system_display_api.cc View 2 chunks +49 lines, -17 lines 0 comments Download
M extensions/browser/api/system_display/system_display_apitest.cc View 4 chunks +70 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/common/api/system_display.idl View 2 chunks +27 lines, -13 lines 0 comments Download
M third_party/closure_compiler/externs/system_display.js View 1 chunk +23 lines, -13 lines 0 comments Download
M third_party/closure_compiler/interfaces/system_display_interface.js View 1 chunk +24 lines, -14 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jdufault
3 years, 11 months ago (2017-01-23 20:27:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
78cf3269633c9134933f70d6087faa42f440dd96.

Powered by Google App Engine
This is Rietveld 408576698