Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2656433003: Add HTML5 integration test (Closed)

Created:
3 years, 11 months ago by Robert Ogden
Modified:
3 years, 11 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add HTML5 integration test BUG=680585 Review-Url: https://codereview.chromium.org/2656433003 Cr-Commit-Position: refs/heads/master@{#446341} Committed: https://chromium.googlesource.com/chromium/src/+/a47a69fb2876f906829c47d8d68910e9e7ee6352

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add ChromeProxy Via assertion #

Total comments: 2

Patch Set 3 : More robust #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A tools/chrome_proxy/webdriver/html5.py View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Robert Ogden
3 years, 11 months ago (2017-01-23 20:08:45 UTC) #2
RyanSturm
https://codereview.chromium.org/2656433003/diff/1/tools/chrome_proxy/webdriver/html5.py File tools/chrome_proxy/webdriver/html5.py (right): https://codereview.chromium.org/2656433003/diff/1/tools/chrome_proxy/webdriver/html5.py#newcode18 tools/chrome_proxy/webdriver/html5.py:18: t.WaitForJavascriptExpression( Verify that the main resource header is valid ...
3 years, 11 months ago (2017-01-25 17:59:46 UTC) #3
Robert Ogden
https://codereview.chromium.org/2656433003/diff/1/tools/chrome_proxy/webdriver/html5.py File tools/chrome_proxy/webdriver/html5.py (right): https://codereview.chromium.org/2656433003/diff/1/tools/chrome_proxy/webdriver/html5.py#newcode18 tools/chrome_proxy/webdriver/html5.py:18: t.WaitForJavascriptExpression( On 2017/01/25 17:59:46, Ryan Sturm wrote: > Verify ...
3 years, 11 months ago (2017-01-25 20:49:50 UTC) #4
RyanSturm
lgtm % suggestion to improve robustness https://codereview.chromium.org/2656433003/diff/20001/tools/chrome_proxy/webdriver/html5.py File tools/chrome_proxy/webdriver/html5.py (right): https://codereview.chromium.org/2656433003/diff/20001/tools/chrome_proxy/webdriver/html5.py#newcode23 tools/chrome_proxy/webdriver/html5.py:23: if (response.url.startswith('http://html5test.com/') and ...
3 years, 11 months ago (2017-01-25 21:06:50 UTC) #5
Robert Ogden
https://codereview.chromium.org/2656433003/diff/20001/tools/chrome_proxy/webdriver/html5.py File tools/chrome_proxy/webdriver/html5.py (right): https://codereview.chromium.org/2656433003/diff/20001/tools/chrome_proxy/webdriver/html5.py#newcode23 tools/chrome_proxy/webdriver/html5.py:23: if (response.url.startswith('http://html5test.com/') and On 2017/01/25 21:06:50, Ryan Sturm wrote: ...
3 years, 11 months ago (2017-01-25 23:05:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656433003/40001
3 years, 11 months ago (2017-01-26 16:01:27 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 16:15:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a47a69fb2876f906829c47d8d689...

Powered by Google App Engine
This is Rietveld 408576698