Add HTML5 integration test

Add HTML5 integration test

BUG=680585
Review-Url: https://codereview.chromium.org/2656433003
Cr-Commit-Position: refs/heads/master@{#446341}
Committed: https://chromium.googlesource.com/chromium/src/+/a47a69fb2876f906829c47d8d68910e9e7ee6352

[Robert Ogden, 2017-01-23 20:08:44]

robertogden@chromium.org changed reviewers:
+ ryansturm@chromium.org

[RyanSturm, 2017-01-25 17:59:46]

https://codereview.chromium.org/2656433003/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/html5.py (right):

https://codereview.chromium.org/2656433003/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/html5.py:18: t.WaitForJavascriptExpression(
Verify that the main resource header is valid (i.e., DRP was used) after this.

[Robert Ogden, 2017-01-25 20:49:50]

https://codereview.chromium.org/2656433003/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/html5.py (right):

https://codereview.chromium.org/2656433003/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/html5.py:18: t.WaitForJavascriptExpression(
On 2017/01/25 17:59:46, Ryan Sturm wrote:
> Verify that the main resource header is valid (i.e., DRP was used) after this.

Done.

[RyanSturm, 2017-01-25 21:06:50]

lgtm % suggestion to improve robustness

https://codereview.chromium.org/2656433003/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/html5.py (right):

https://codereview.chromium.org/2656433003/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/html5.py:23: if
(response.url.startswith('http://html5test.com/') and
If there is a way to filter to the exact match instead of startswith, we might
be better off.

In general, POSTs won't be handled which could be forms and not XHR maybe (I
don't know), but at the same time, all this has to test is that the main
resource is tested, hence the exact match.

I think it will be more robust if we only test one resource if we are using a
webpage that can change unexpectedly.

[Robert Ogden, 2017-01-25 23:05:31]

https://codereview.chromium.org/2656433003/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/html5.py (right):

https://codereview.chromium.org/2656433003/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/html5.py:23: if
(response.url.startswith('http://html5test.com/') and
On 2017/01/25 21:06:50, Ryan Sturm wrote:
> If there is a way to filter to the exact match instead of startswith, we might
> be better off.
> 
> In general, POSTs won't be handled which could be forms and not XHR maybe (I
> don't know), but at the same time, all this has to test is that the main
> resource is tested, hence the exact match.
> 
> I think it will be more robust if we only test one resource if we are using a
> webpage that can change unexpectedly.

Done.

[Robert Ogden, 2017-01-26 16:01:06]

The CQ bit was checked by robertogden@chromium.org

[Robert Ogden, 2017-01-26 16:01:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2656433003/#ps40001
(title: "More robust")

[commit-bot: I haz the power, 2017-01-26 16:01:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 16:14:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485446466954500,
"parent_rev": "7ff9ceb9be03477632e2808268882889ff551185", "commit_rev":
"a47a69fb2876f906829c47d8d68910e9e7ee6352"}

[commit-bot: I haz the power, 2017-01-26 16:15:26]

Description was changed from

==========
Add HTML5 integration test

BUG=680585
==========

to

==========
Add HTML5 integration test

BUG=680585

Review-Url: https://codereview.chromium.org/2656433003
Cr-Commit-Position: refs/heads/master@{#446341}
Committed:
https://chromium.googlesource.com/chromium/src/+/a47a69fb2876f906829c47d8d689...
==========

[commit-bot: I haz the power, 2017-01-26 16:15:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a47a69fb2876f906829c47d8d689...