PPC/s390: [turbofan] Introduce JSCallForwardVarargs operator.

PPC/s390: [turbofan] Introduce JSCallForwardVarargs operator.

Port 69747e2658f1de973ba75c60fe31b402bd6031a5

Original Commit Message:

    We turn a JSCallFunction node for

      f.apply(receiver, arguments)

    into a JSCallForwardVarargs node, when the arguments refers to the
    arguments of the outermost optimized code object, i.e. not an inlined
    arguments, and the apply method refers to Function.prototype.apply,
    and there's no other user of arguments except in frame states.

    We also replace the arguments node in the graph with a marker for
    the Deoptimizer similar to Crankshaft to make sure we don't materialize
    unused arguments just for the sake of deoptimization. We plan to replace
    this with a saner EscapeAnalysis based solution soon.

R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=v8:5267, v8:5726
LOG=N

Review-Url: https://codereview.chromium.org/2656363002
Cr-Commit-Position: refs/heads/master@{#42745}
Committed: https://chromium.googlesource.com/v8/v8/+/e6688728578d7cbd7434400076fbc679105ef24b

[JaideepBajwa, 2017-01-27 17:20:28]

ptal

[john.yan, 2017-01-27 17:23:21]

lgtm

[JaideepBajwa, 2017-01-27 17:24:19]

The CQ bit was checked by bjaideep@ca.ibm.com

[commit-bot: I haz the power, 2017-01-27 17:24:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 17:48:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485537859984960, "parent_rev":
"53667c89b09cb795b66e56ff8fcd1f691ee7c773", "commit_rev":
"e6688728578d7cbd7434400076fbc679105ef24b"}

[commit-bot: I haz the power, 2017-01-27 17:48:41]

Description was changed from

==========
PPC/s390: [turbofan] Introduce JSCallForwardVarargs operator.

Port 69747e2658f1de973ba75c60fe31b402bd6031a5

Original Commit Message:

    We turn a JSCallFunction node for

      f.apply(receiver, arguments)

    into a JSCallForwardVarargs node, when the arguments refers to the
    arguments of the outermost optimized code object, i.e. not an inlined
    arguments, and the apply method refers to Function.prototype.apply,
    and there's no other user of arguments except in frame states.

    We also replace the arguments node in the graph with a marker for
    the Deoptimizer similar to Crankshaft to make sure we don't materialize
    unused arguments just for the sake of deoptimization. We plan to replace
    this with a saner EscapeAnalysis based solution soon.

R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com
BUG=v8:5267,v8:5726
LOG=N
==========

to

==========
PPC/s390: [turbofan] Introduce JSCallForwardVarargs operator.

Port 69747e2658f1de973ba75c60fe31b402bd6031a5

Original Commit Message:

    We turn a JSCallFunction node for

      f.apply(receiver, arguments)

    into a JSCallForwardVarargs node, when the arguments refers to the
    arguments of the outermost optimized code object, i.e. not an inlined
    arguments, and the apply method refers to Function.prototype.apply,
    and there's no other user of arguments except in frame states.

    We also replace the arguments node in the graph with a marker for
    the Deoptimizer similar to Crankshaft to make sure we don't materialize
    unused arguments just for the sake of deoptimization. We plan to replace
    this with a saner EscapeAnalysis based solution soon.

R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com
BUG=v8:5267,v8:5726
LOG=N

Review-Url: https://codereview.chromium.org/2656363002
Cr-Commit-Position: refs/heads/master@{#42745}
Committed:
https://chromium.googlesource.com/v8/v8/+/e6688728578d7cbd7434400076fbc679105...
==========

[commit-bot: I haz the power, 2017-01-27 17:48:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e6688728578d7cbd7434400076fbc679105...

[john.yan, 2017-04-26 16:48:20]

https://codereview.chromium.org/2656363002/diff/1/src/builtins/s390/builtins-...
File src/builtins/s390/builtins-s390.cc (right):

https://codereview.chromium.org/2656363002/diff/1/src/builtins/s390/builtins-...
src/builtins/s390/builtins-s390.cc:2332: __ CmpSmiLiteral(ip,
Smi::FromInt(StackFrame::ARGUMENTS_ADAPTOR), r0);
ip was pointer size (LoadP) here. Maybe try to use LoadSmiLiteral + CmpP here?

https://codereview.chromium.org/2656363002/diff/1/src/builtins/s390/builtins-...
src/builtins/s390/builtins-s390.cc:2352: __ CmpP(r2, Operand::Zero());
CmpP isn't necessary here since SubP sets CC implicitly.

https://codereview.chromium.org/2656363002/diff/1/src/builtins/s390/builtins-...
src/builtins/s390/builtins-s390.cc:2369: __ CmpP(r4, Operand::Zero());
Same as above.